Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed missing incoming recommendations #21317

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

sagzy
Copy link
Contributor

@sagzy sagzy commented Oct 16, 2024

ref https://linear.app/tryghost/issue/ONC-433

  • due to a regression introduced in commit 871d21a, incoming recommendations were not rendering in Admin Settings anymore, as they were marked as deleted
  • this commit updates the refresh logic of incoming recommendations on boot: previously deleted incoming recommendations are refetched, and if now available, restored
  • when a recommendation is restored, we don't send a staff email notification

ref https://linear.app/tryghost/issue/ONC-433

- due to a regression introduced in commit 871d21a, incoming recommendations were not rendering in Admin Settings anymore, as they were marked as deleted
- this commit updates the refresh logic of incoming recommendations on boot: previously deleted incoming recommendations are refetched, and if now available, restored
- when a recommendation is restored, we don't send a staff email notification
@sagzy sagzy merged commit 6ee3d05 into main Oct 16, 2024
21 checks passed
@sagzy sagzy deleted the inc-112/backfill-missing-recs branch October 16, 2024 09:00
sagzy added a commit that referenced this pull request Oct 16, 2024
ref https://linear.app/tryghost/issue/ONC-433

- due to a regression introduced in commit 871d21a, incoming
recommendations were not rendering in Admin Settings anymore, as they
were marked as deleted
- this commit updates the refresh logic of incoming recommendations on
boot: previously deleted incoming recommendations are refetched, and if
now available, restored
- when a recommendation is restored, we don't send a staff email
notification
dvdwinden pushed a commit that referenced this pull request Oct 24, 2024
ref https://linear.app/tryghost/issue/ONC-433

- due to a regression introduced in commit 871d21a, incoming
recommendations were not rendering in Admin Settings anymore, as they
were marked as deleted
- this commit updates the refresh logic of incoming recommendations on
boot: previously deleted incoming recommendations are refetched, and if
now available, restored
- when a recommendation is restored, we don't send a staff email
notification
tilak999 pushed a commit to tilak999/ghost that referenced this pull request Nov 20, 2024
ref https://linear.app/tryghost/issue/ONC-433

- due to a regression introduced in commit 871d21a, incoming
recommendations were not rendering in Admin Settings anymore, as they
were marked as deleted
- this commit updates the refresh logic of incoming recommendations on
boot: previously deleted incoming recommendations are refetched, and if
now available, restored
- when a recommendation is restored, we don't send a staff email
notification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant