Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Nepali locale for Ghost #21552

Merged
merged 8 commits into from
Nov 15, 2024
Merged

Added Nepali locale for Ghost #21552

merged 8 commits into from
Nov 15, 2024

Conversation

sparshrestha
Copy link
Contributor

@sparshrestha sparshrestha commented Nov 6, 2024

  • Created a new folder ne based on locale code for Nepali locale inside ghost/i18n/locales/
  • Cloned 6 new JSON files pertaining to en folder from English locale.
  • Added all field translations from English to Nepali for ghost.json file.
  • Added all field translations from English to Nepali for search.json file.
  • Added all field translations from English to Nepali for signup-form.json file.
  • TODO: Remaining 3 other files viz. comments, newsletter, and portal.

"Thank you for creating Ghost and making it open source.": "Ghost सिर्जना गरेर यसलाई ओपन सोर्स बनाउनु भएकोमा धन्यवाद।"

@sparshrestha sparshrestha changed the title Added Nepali locale for ghost.json Added Nepali locale for Ghost Nov 6, 2024
@cathysarisky
Copy link
Contributor

You will also need to update the SUPPORTED_LOCALES in i18n.js to include this one.

Line 36 with locale code `ne`
@sparshrestha
Copy link
Contributor Author

sparshrestha commented Nov 7, 2024

Copy link
Contributor

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An AI review of ghost.json looks good. If you plan to add the other translation files, we can wait a bit before merging?

@sparshrestha
Copy link
Contributor Author

sparshrestha commented Nov 11, 2024

Thank you @cathysarisky
Sure. I'll add more in the days to come.

Copy link
Contributor

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These pass an AI check.

@9larsons 9larsons enabled auto-merge (squash) November 15, 2024 16:59
@9larsons 9larsons merged commit dba01d1 into TryGhost:main Nov 15, 2024
21 checks passed
9larsons pushed a commit that referenced this pull request Nov 15, 2024
no ref

- [x] Created a new folder `ne` based on locale code for Nepali locale
inside `ghost/i18n/locales/`
- [x] Cloned 6 new JSON files pertaining to `en` folder from English
locale.
- [x] Added all field translations from English to Nepali for
`ghost.json` file.
- [x] Added all field translations from English to Nepali for
`search.json` file.
- [x] Added all field translations from English to Nepali for
`signup-form.json` file.
- [ ] TODO: Remaining 3 other files viz. `comments`, `newsletter`, and
`portal`.


"Thank you for creating Ghost and making it open source.": "Ghost
सिर्जना गरेर यसलाई ओपन सोर्स बनाउनु भएकोमा धन्यवाद।"
@sparshrestha
Copy link
Contributor Author

#21635 - Added Nepali locale for newsletter.json

tilak999 pushed a commit to tilak999/ghost that referenced this pull request Nov 20, 2024
no ref

- [x] Created a new folder `ne` based on locale code for Nepali locale
inside `ghost/i18n/locales/`
- [x] Cloned 6 new JSON files pertaining to `en` folder from English
locale.
- [x] Added all field translations from English to Nepali for
`ghost.json` file.
- [x] Added all field translations from English to Nepali for
`search.json` file.
- [x] Added all field translations from English to Nepali for
`signup-form.json` file.
- [ ] TODO: Remaining 3 other files viz. `comments`, `newsletter`, and
`portal`.


"Thank you for creating Ghost and making it open source.": "Ghost
सिर्जना गरेर यसलाई ओपन सोर्स बनाउनु भएकोमा धन्यवाद।"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants