Changed location of built public content to temporary dir #21857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike182uk
force-pushed
the
mike-onc-662-fix-file-write-issues-in-ghost-application-related-to-asset
branch
6 times, most recently
from
8c23bb0 to
393afa2
Compare
refs [ONC-662](https://linear.app/ghost/issue/ONC-662/fix-file-write-issues-in-ghost-application-related-to-asset-generation) Changed location of built public content to temporary dir to circumvent file writing issues in some environments (i.e gluster). This is a stop-gap measure until we get to refactoring the generation of the built public content.
mike182uk
force-pushed
the
mike-onc-662-fix-file-write-issues-in-ghost-application-related-to-asset
branch
from
393afa2 to
822966f
Compare
mike182uk
force-pushed
the
mike-onc-662-fix-file-write-issues-in-ghost-application-related-to-asset
branch
from
78a88b0 to
0e4fde0
Compare
mike182uk
force-pushed
the
mike-onc-662-fix-file-write-issues-in-ghost-application-related-to-asset
branch
from
0e4fde0 to
6938f7f
Compare
mike182uk
deleted the
mike-onc-662-fix-file-write-issues-in-ghost-application-related-to-asset
branch
mike182uk
added a commit
that referenced
this pull request
Dec 11, 2024
refs [ONC-662](https://linear.app/ghost/issue/ONC-662/fix-file-write-issues-in-ghost-application-related-to-asset-generation) Changed location of built public content to temporary dir to circumvent file writing issues in some environments (i.e gluster). This is a stop-gap measure until we get to refactoring the generation of the built public content.
mike182uk
added a commit
that referenced
this pull request
Dec 12, 2024
refs [ONC-662](https://linear.app/ghost/issue/ONC-662/fix-file-write-issues-in-ghost-application-related-to-asset-generation) Refactored the generation of the following assets: - `comment-counts.js` - `member-attribution.js` - `admin-auth` To occur at build time instead of at boot time or on demand This also reverts the changes made in [#21857](#21857) as these changes are no longer needed (because the assets are now generated at build time)
mike182uk
added a commit
that referenced
this pull request
Dec 12, 2024
refs [ONC-662](https://linear.app/ghost/issue/ONC-662/fix-file-write-issues-in-ghost-application-related-to-asset-generation) Refactored the generation of the following assets: - `comment-counts.js` - `member-attribution.js` - `admin-auth` To occur at build time instead of at boot time or on demand This also reverts the changes made in [#21857](#21857) as these changes are no longer needed (because the assets are now generated at build time)
mike182uk
added a commit
that referenced
this pull request
Dec 12, 2024
refs [ONC-662](https://linear.app/ghost/issue/ONC-662/fix-file-write-issues-in-ghost-application-related-to-asset-generation) Refactored the generation of the following assets: - `comment-counts.js` - `member-attribution.js` - `admin-auth` To occur at build time instead of at boot time or on demand `cards` are still built on demand as these assets need to be re-generated when a theme changes - we utilise the existing asset minification system for this, except we only execute the middleware responsible for this when a request is requesting a card asset This also reverts the changes made in [#21857](#21857) as these changes are no longer needed (because the assets are now generated at build time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ONC-662
Changed location of built public content to temporary dir to circumvent file writing issues in some environments (i.e gluster). This is a stop-gap measure until we get to refactoring the generation of the built public content.