Skip to content

Removed site.changed event for AP #22905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vershwal merged 4 commits into from
Apr 21, 2025
Merged

Removed site.changed event for AP #22905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a39da10
Removed site.changed event for AP
vershwal Apr 15, 2025
c6cb73e
Merge branch 'main' into ap-1063-remove-site-sync
vershwal Apr 15, 2025
b842806
Updated tests to expect 1 webhook
vershwal Apr 15, 2025
f9df584
Merge branch 'main' into ap-1063-remove-site-sync
vershwal Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ghost/core/core/server/services/activitypub/ActivityPubService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ export class ActivityPubService {
target_url: new URL('.ghost/activitypub/webhooks/post/published', this.siteUrl),
api_version: 'v5.100.0',
secret
}, {
event: 'site.changed',
target_url: new URL('.ghost/activitypub/webhooks/site/changed', this.siteUrl),
api_version: 'v5.100.0',
secret
}];
}

Expand Down
6 changes: 3 additions & 3 deletions ghost/core/test/unit/server/services/activitypub/ActivityPubService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ describe('ActivityPubService', function () {

const webhooks = await knexInstance.select('*').from('webhooks');

const expectedWebhookCount = 2;
const expectedWebhookCount = 1;
const expectedWebhookSecret = 'webhook_secret_baby!!';
const expectedWebhookIntegrationId = 'integration_id';

Expand Down Expand Up @@ -154,7 +154,7 @@ describe('ActivityPubService', function () {

const webhooks = await knexInstance.select('*').from('webhooks');

const expectedWebhookCount = 2;
const expectedWebhookCount = 1;
const expectedWebhookSecret = 'webhook_secret_baby!!';
const expectedWebhookIntegrationId = 'integration_id';

Expand Down Expand Up @@ -213,7 +213,7 @@ describe('ActivityPubService', function () {

const webhooks = await knexInstance.select('*').from('webhooks');

const expectedWebhookCount = 2;
const expectedWebhookCount = 1;
const expectedWebhookSecret = 'webhook_secret_baby!!';
const expectedWebhookIntegrationId = 'integration_id';

Expand Down