preventDefault on notifications #2528
Conversation
|
@AgtLucas without an explanation of why your change is needed, I have no way to verify this PR. Please read our contributing guidelines. We're also in the process of completely rewriting the Ghost admin in Ember, so perhaps you'd like to get involved in that? |
|
@ErisDS Sorry about that, was my mistake. So, the reason for this PR it's because when you click to close one notification in admin, the URL get hash. I know that SEO in admin it's not important, and this sounds stupid but, IMHO, urls shouldn't get hash after you click in something. I don't know why the Travis build failed. About Ember, I read about that on dev blog, sounds really interesting, besides the fact I'm most familiar with Backbone and Angular, after reading #2144 I'm sure you guys did the best choice. Thanks :) |
|
I agree about preventing unnecessary hashes, but it does tend to be a personal taste thing. Part of the reason I propose switching to void(0) in #916. Based on quick google search, Ember automatically inserts the event.preventDefault for actions. So this should be handled in Admin++. |
|
Ember automatically does this for us, so even if I merge it it'll only be in the codebase a short while, which I would do except this doesn't meet our contributing guidelines |
|
This'll get done in the Ember project. |
No description provided.