Skip to content

Moved to kebab-case formatting signup-form#25463

Merged
ibalosh merged 3 commits intomainfrom
move-to-kebab-case-formatting-signup-form
Nov 18, 2025
Merged

Moved to kebab-case formatting signup-form#25463
ibalosh merged 3 commits intomainfrom
move-to-kebab-case-formatting-signup-form

Conversation

@ibalosh
Copy link
Contributor

@ibalosh ibalosh commented Nov 17, 2025

ref https://linear.app/ghost/issue/NY-722/migrate-ghost-codebase-to-kebab-case-file-naming-convention

what

  • Renamed all files to match to kebab-case format
  • Added ESLint kebab-case linting rules
  • Updated readme to make it consistent with other micro apps that require separate release with publishing package

why

  • To match our working agreement on filenames in Ghost repo

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 17, 2025

Walkthrough

This pull request renames multiple source files in the signup-form app from PascalCase to kebab-case and updates all corresponding import paths to match (e.g., AppContext.tsxapp-context.tsx, FormPage.tsxform-page.tsx). Adds an ESLint rule ghost/filenames/match-regex enforcing the filename pattern ^[a-z0-9.-]+$. Updates apps/signup-form/package.json version and adds a Release section to apps/signup-form/README.md. No runtime logic, control flow, or public API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10–15 minutes

  • Validate import path updates across all renamed files (multiple files under apps/signup-form/src — ~13+ changes).
  • Confirm ESLint rule configuration (ghost/filenames/match-regex with ^[a-z0-9.-]+$) is intentional and consistent with repository conventions.
  • Verify apps/signup-form/package.json version bump and README release instructions are correct and complete.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly reflects the main change: converting the signup-form project to kebab-case formatting for file and directory naming conventions.
Description check ✅ Passed The description clearly explains what was changed (kebab-case file renaming, ESLint rules added, README updated), why it was done (compliance with repository naming conventions), and references the relevant Linear issue.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch move-to-kebab-case-formatting-signup-form

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b738ffa and f9f6295.

📒 Files selected for processing (2)
  • apps/signup-form/package.json (1 hunks)
  • ghost/core/core/shared/config/defaults.json (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • apps/signup-form/package.json
  • ghost/core/core/shared/config/defaults.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Setup
  • GitHub Check: Build & Push
  • GitHub Check: Setup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

 - renamed files to kebab-case

Changelog for v0.3.2 -> 0.3.3:
@ibalosh ibalosh requested review from 9larsons and cmraible November 17, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments