Skip to content

Removed unused tinybird filters#25477

Merged
9larsons merged 5 commits intomainfrom
rm-tb-pipes-unused
Nov 18, 2025
Merged

Removed unused tinybird filters#25477
9larsons merged 5 commits intomainfrom
rm-tb-pipes-unused

Conversation

@9larsons
Copy link
Contributor

ref 1633eab
ref a6adad1

Cleaned up unused filters. This is an addendum to the original commit and reversion commit (above).

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 18, 2025

Walkthrough

This pull request removes device, browser, and OS filters from Tinybird SQL pipe templates and related test fixtures. Changes include deleting conditional filter clauses in multiple .pipe endpoint files (api_kpis, api_top_locations, api_top_pages, filtered_sessions), removing corresponding test cases across several tests/*.yaml fixtures, and removing three Tinybird pipe entries (api_top_browsers, api_top_devices, api_top_os) from TinybirdService.js. Other filters and surrounding logic remain unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

  • Verify each .pipe file no longer references device, browser, or os and that SQL remains syntactically valid after removals.
  • Review all modified YAML test fixtures to ensure expected_result adjustments match remaining filters and no test structure was corrupted.
  • Confirm TinybirdService.js removals align with available pipes and that no runtime references to the removed pipe names remain.
  • Check for any remaining codepaths or docs referencing the removed filters (e.g., parameter parsing, validation, or telemetry).

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removal of unused Tinybird filters from the codebase, matching the deletions across multiple pipe and test files.
Description check ✅ Passed The description is related to the changeset, referencing prior commits and identifying the work as cleanup of unused Tinybird filters, which aligns with the file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rm-tb-pipes-unused

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d4c6be and b1ac58b.

📒 Files selected for processing (1)
  • ghost/core/core/server/data/tinybird/tests/api_kpis.yaml (0 hunks)
💤 Files with no reviewable changes (1)
  • ghost/core/core/server/data/tinybird/tests/api_kpis.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Acceptance tests (Node 22.13.1, mysql8)
  • GitHub Check: Legacy tests (Node 22.13.1, mysql8)
  • GitHub Check: Acceptance tests (Node 22.13.1, sqlite3)
  • GitHub Check: Unit tests (Node 22.13.1)
  • GitHub Check: Legacy tests (Node 22.13.1, sqlite3)
  • GitHub Check: Ghost-CLI tests
  • GitHub Check: Tinybird Tests
  • GitHub Check: Lint
  • GitHub Check: i18n
  • GitHub Check: Build & Push

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons 9larsons enabled auto-merge (squash) November 18, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments