Updated to latest version of ESlint ghost plugin

apps/activitypub/src/api/activitypub.ts

@@ -254,7 +254,7 @@ export class ActivityPubAPI {
             const response = await this.fetch(this.authApiUrl);
             const json = await response.json();
             return json?.identities?.[0]?.token || null;
-        } catch (err) {
+        } catch {
             // TODO: Ping sentry?
             return null;
         }

apps/activitypub/src/components/modals/new-note-modal.tsx

@@ -93,7 +93,7 @@ const NewNoteModal: React.FC<NewNoteModalProps> = ({children, replyTo, onReply,
                 onOpenChange(false);
             }
             toast.success(replyTo ? 'Reply posted' : 'Note posted');
-        } catch (error) {
+        } catch {
             if (replyTo) {
                 onReplyError?.();
             }

apps/activitypub/src/hooks/use-activity-pub-queries.ts

@@ -396,7 +396,7 @@ function updateNotificationsLikedCache(queryClient: QueryClient, handle: string,
                         };
                     })
                 };
-            } catch (error) {
+            } catch {
                 return current;
             }
         }
@@ -442,7 +442,7 @@ function updateNotificationsRepostCache(queryClient: QueryClient, handle: string
                         };
                     })
                 };
-            } catch (error) {
+            } catch {
                 return current;
             }
         }
@@ -487,7 +487,7 @@ function updateNotificationsReplyCountCache(queryClient: QueryClient, handle: st
                         };
                     })
                 };
-            } catch (error) {
+            } catch {
                 return current;
             }
         }

apps/activitypub/src/utils/get-username.ts

@@ -4,7 +4,7 @@ function getUsername(actor: {preferredUsername: string; id: string|null;}) {
     }
     try {
         return `@${actor.preferredUsername}@${(new URL(actor.id)).hostname.replace(/^www\./, '')}`;
-    } catch (err) {
+    } catch {
         return '@unknown@unknown';
     }
 }

apps/activitypub/src/utils/image.ts

@@ -22,7 +22,7 @@ export const imageUrlToDataUrl = async (url: string): Promise<string> => {
             reader.onerror = reject;
             reader.readAsDataURL(blob);
         });
-    } catch (error) {
+    } catch {
         // Return original URL as fallback if conversion fails
         return url;
     }

apps/activitypub/src/views/preferences/components/bluesky-sharing.tsx

@@ -52,7 +52,7 @@ const BlueskySharing: React.FC = () => {
             setLoading(true);
             try {
                 await enableBlueskyMutation.mutateAsync();
-            } catch (error) {
+            } catch {
                 setLoading(false);
                 toast.error('Something went wrong, please try again.');
             }

apps/activitypub/src/views/preferences/components/profile.tsx

@@ -304,11 +304,11 @@ const Profile: React.FC<ProfileProps> = ({account, isLoading}) => {
 
                 await navigator.clipboard.write([clipboardItem]);
                 toast.success('Image copied to clipboard');
-            } catch (error) {
+            } catch {
                 toast.error('Failed to copy image');
             }
             setIsProcessing(false);
-        } catch (error) {
+        } catch {
             toast.error('Failed to copy image');
             setIsProcessing(false);
         }

apps/activitypub/src/views/profile/profile.tsx

@@ -10,6 +10,7 @@ import {useParams} from '@tryghost/admin-x-framework';
 
 export type ProfileTab = 'posts' | 'likes' | 'following' | 'followers';
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 interface ProfileProps {}
 
 const PostsTab:React.FC<{handle: string}> = ({handle}) => {

apps/admin-x-design-system/src/global/sortable-list.tsx

@@ -14,7 +14,7 @@ export interface SortableItemContainerProps {
     isDragging: boolean;
     dragHandleAttributes?: DraggableAttributes;
     // TODO: figure out a stricter alternative for Function
-    // eslint-disable-next-line @typescript-eslint/ban-types
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
     dragHandleListeners?: Record<string, Function>;
     dragHandleClass?: string;
     style?: React.CSSProperties;

apps/admin-x-design-system/src/typings.d.ts

@@ -1,4 +1,5 @@
 declare module '*.svg' {
+    // eslint-disable-next-line @typescript-eslint/no-require-imports
     import React = require('react');
     export const ReactComponent: React.FC<React.SVGProps<SVGSVGElement>>;
     const src: string;

apps/admin-x-design-system/src/utils/format-url.ts

@@ -45,7 +45,7 @@ export const formatUrl = (value: string, baseUrl?: string, nullable?: boolean) =
 
     try {
         parsedUrl = new URL(url, baseUrl);
-    } catch (e) {
+    } catch {
         return {save: url, display: url};
     }
 

apps/admin-x-framework/src/api/config.ts

@@ -2,6 +2,8 @@ import {createQuery} from '../utils/api/hooks';
 
 export type JSONValue = string|number|boolean|null|Date|JSONObject|JSONArray;
 export interface JSONObject { [key: string]: JSONValue }
+
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 interface JSONArray extends Array<string|number|boolean|Date|JSONObject|JSONValue> {}
 
 export type Config = {

apps/admin-x-framework/src/api/recommendations.ts

@@ -22,9 +22,10 @@ export interface RecommendationResponseType {
     recommendations: Recommendation[]
 }
 
-export interface RecommendationEditResponseType extends RecommendationResponseType {
-}
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
+export interface RecommendationEditResponseType extends RecommendationResponseType {}
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 export interface RecommendationDeleteResponseType {}
 
 const dataType = 'RecommendationResponseType';

apps/admin-x-framework/src/test/acceptance.ts

@@ -127,7 +127,7 @@ export function toggleLabsFlag(flag: string, value: boolean) {
     let labs: LabsSettings;
     try {
         labs = JSON.parse(labsSetting.value);
-    } catch (e) {
+    } catch {
         throw new Error('Failed to parse labs settings');
     }
 

apps/admin-x-framework/src/test/test-utils.tsx

@@ -236,7 +236,7 @@ export const testDataFactories = {
  * Mock timer utilities
  */
 export function mockTimers() {
-    // eslint-disable-next-line @typescript-eslint/no-var-requires
+    // eslint-disable-next-line @typescript-eslint/no-require-imports
     const vitest = require('vitest');
     vitest.vi.useFakeTimers();
 

apps/admin-x-framework/test/unit/hooks/use-form.test.ts

@@ -203,7 +203,7 @@ describe('useForm', () => {
                 await act(async () => {
                     await result.current!.handleSave();
                 });
-            } catch (e) {
+            } catch {
                 // Expected to throw
             }
 
@@ -230,7 +230,7 @@ describe('useForm', () => {
                 await act(async () => {
                     await result.current!.handleSave();
                 });
-            } catch (e) {
+            } catch {
                 // Expected to throw
             }
 

apps/admin-x-settings/src/components/settings/email/newsletters/newsletter-detail-modal.tsx

@@ -779,6 +779,7 @@ const NewsletterDetailModalContent: React.FC<{newsletter: Newsletter; onlyOne: b
         initialState: newsletter,
         savingDelay: 500,
         onSave: async () => {
+            // eslint-disable-next-line @typescript-eslint/no-unused-expressions
             const {meta: {sent_email_verification: [emailToVerify] = []} = {}} = await editNewsletter(formState); ``;
             let toastMessage;
 

apps/admin-x-settings/src/components/settings/growth/recommendations/add-recommendation-modal-confirm.tsx

@@ -109,7 +109,7 @@ const AddRecommendationModalConfirm: React.FC<AddRecommendationModalProps> = ({r
             dismissAllToasts();
             try {
                 await handleSave({force: true});
-            } catch (e) {
+            } catch {
                 showToast({
                     type: 'error',
                     title: 'Something went wrong when adding this recommendation, please try again.'

apps/admin-x-settings/src/components/settings/growth/recommendations/add-recommendation-modal.tsx

@@ -26,7 +26,7 @@ const validateUrl = function (errors: ErrorMessages, url: string) {
         } else {
             delete errors.url;
         }
-    } catch (e) {
+    } catch {
         errors.url = 'Enter a valid URL';
     }
     return errors;

apps/admin-x-settings/src/components/settings/growth/recommendations/edit-recommendation-modal.tsx

@@ -84,7 +84,7 @@ const EditRecommendationModal: React.FC<RoutingModalProps & EditRecommendationMo
             dismissAllToasts();
             try {
                 await handleSave({force: true});
-            } catch (e) {
+            } catch {
                 showToast({
                     title: 'Something went wrong',
                     type: 'error',

apps/admin-x-settings/src/components/settings/growth/recommendations/incoming-recommendation-list.tsx

@@ -22,7 +22,7 @@ const IncomingRecommendationItem: React.FC<{incomingRecommendation: IncomingReco
         let cleanedDomain = incomingRecommendation.url;
         try {
             cleanedDomain = new URL(incomingRecommendation.url).hostname.replace(/^www\./, '');
-        } catch (_) {
+        } catch {
             // Ignore invalid urls
         }
 

apps/admin-x-settings/src/components/settings/site/navigation/navigation-item-editor.tsx

@@ -36,6 +36,7 @@ const NavigationItemEditor: React.FC<NavigationItemEditorProps> = ({baseUrl, ite
                             e.preventDefault();
                             addItem?.();
                         }
+                        // eslint-disable-next-line @typescript-eslint/no-unused-expressions
                         !!item.errors.label && clearError?.('label');
                     }}
                 />
@@ -63,6 +64,7 @@ const NavigationItemEditor: React.FC<NavigationItemEditorProps> = ({baseUrl, ite
                             updateItem?.({url: urls.save || ''});
                             addItem?.();
                         }
+                        // eslint-disable-next-line @typescript-eslint/no-unused-expressions
                         !!item.errors.url && clearError?.('url');
                     }}
                 />

apps/admin-x-settings/src/typings.d.ts

@@ -2,6 +2,7 @@ declare module '@tryghost/limit-service'
 declare module '@tryghost/nql'
 
 declare module '*.svg' {
+    // eslint-disable-next-line @typescript-eslint/no-require-imports
     import React = require('react');
     export const ReactComponent: React.FC<React.SVGProps<SVGSVGElement>>;
     const src: string;

apps/admin-x-settings/src/utils/link-to-github-releases.ts

@@ -1,3 +1,4 @@
+// @ts-expect-error - semver subpath has no types
 import semverParse from 'semver/functions/parse';
 
 // This function needs to support:
@@ -29,7 +30,7 @@ export function linkToGitHubReleases(version: string): string {
         }
 
         return `https://github.com/TryGhost/Ghost/releases/tag/v${cleanedVersion}`;
-    } catch (e) {
+    } catch {
         return '';
     }
 }

apps/admin-x-settings/src/utils/url.ts

@@ -27,7 +27,7 @@ export function arePathsEqual(urlStr1: string, urlStr2: string) {
     try {
         url1 = new URL(urlStr1);
         url2 = new URL(urlStr2);
-    } catch (e) {
+    } catch {
         return false;
     }
 

apps/admin/eslint.config.js

@@ -7,20 +7,6 @@ import { globalIgnores } from 'eslint/config'
 import noRelativeImportPaths from 'eslint-plugin-no-relative-import-paths'
 import ghostPlugin from 'eslint-plugin-ghost';
 
-// Patch the filenames/match-regex rule to add schema for ESLint 9 compatibility
-// TODO: Remove once eslint-plugin-ghost is updated
-const matchRegexRule = ghostPlugin.rules['filenames/match-regex'];
-ghostPlugin.rules['filenames/match-regex'] = {
-  create: matchRegexRule,
-  meta: {
-    schema: [
-      { type: 'string' },
-      { type: 'boolean' },
-      { type: 'boolean' }
-    ]
-  }
-};
-
 export default tseslint.config([
   globalIgnores(['dist']),
   {

apps/admin/package.json

@@ -38,7 +38,7 @@
     "jsdom": "24.1.0",
     "sirv": "3.0.2",
     "typescript": "5.8.3",
-    "typescript-eslint": "8.46.1",
+    "typescript-eslint": "8.49.0",
     "vite": "7.1.12",
     "vite-tsconfig-paths": "5.1.4",
     "vitest": "4.0.5"

apps/comments-ui/src/actions.ts

@@ -259,7 +259,7 @@ async function likeComment({api, data: comment, dispatchAction}: {state: Editabl
     try {
         await api.comments.like({comment});
         return {};
-    } catch (err) {
+    } catch {
         dispatchAction('updateCommentLikeState', {id: comment.id, liked: false});
     }
 }
@@ -270,7 +270,7 @@ async function unlikeComment({api, data: comment, dispatchAction}: {state: Edita
     try {
         await api.comments.unlike({comment});
         return {};
-    } catch (err) {
+    } catch {
         dispatchAction('updateCommentLikeState', {id: comment.id, liked: true});
     }
 }

apps/comments-ui/src/app-context.ts

@@ -90,7 +90,6 @@ export type TranslationFunction = (key: string, replacements?: Record<string, st
 
 export type AppContextType = EditableAppContext & CommentsOptions & {
     // This part makes sure we can add automatic data and return types to the actions when using context.dispatchAction('actionName', data)
-    // eslint-disable-next-line @typescript-eslint/ban-types
     t: TranslationFunction,
     dispatchAction: <T extends ActionType | SyncActionType>(action: T, data: Parameters<(typeof Actions & typeof SyncActions)[T]>[0] extends { data: any } ? Parameters<(typeof Actions & typeof SyncActions)[T]>[0]['data'] : any) => T extends ActionType ? Promise<void> : void,
     openFormCount: number
@@ -116,7 +115,7 @@ export const useLabs = () => {
     try {
         const context = useAppContext();
         return context.labs || {};
-    } catch (e) {
+    } catch {
         return {};
     }
 };

apps/comments-ui/src/components/content/forms/form.tsx

@@ -75,7 +75,7 @@ export const FormEditor: React.FC<FormEditorProps> = ({comment, submit, progress
             await submit({
                 html: editor.getHTML()
             });
-        } catch (e) {
+        } catch {
             setProgress('error');
             return;
         }

apps/comments-ui/src/components/popup-box.tsx

@@ -4,7 +4,7 @@ import {useAppContext} from '../app-context';
 import {useEffect, useState} from 'react';
 
 // TODO: figure out what this type should be?
-// eslint-disable-next-line @typescript-eslint/ban-types
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 type Props = {};
 
 const PopupBox: React.FC<Props> = () => {

apps/comments-ui/src/typings.d.ts

@@ -1,4 +1,5 @@
 declare module '*.svg' {
+    // eslint-disable-next-line @typescript-eslint/no-require-imports
     import React = require('react');
     export const ReactComponent: React.FC<React.SVGProps<SVGSVGElement>>;
     const src: string;

apps/comments-ui/src/utils/admin-api.ts

@@ -15,7 +15,7 @@ export function setupAdminAPI({adminUrl}: {adminUrl: string}) {
         let data = null;
         try {
             data = JSON.parse(event.data);
-        } catch (err) {
+        } catch {
             return;
         }
 

apps/comments-ui/src/utils/api.ts

@@ -314,7 +314,7 @@ function setupGhostApi({siteUrl = window.location.origin, apiUrl, apiKey}: {site
             if (settings.settings.labs) {
                 Object.assign(labs, settings.settings.labs);
             }
-        } catch (e) {
+        } catch {
             labs = {};
         }
 

apps/posts/src/hooks/use-post-success-modal.ts

@@ -163,7 +163,7 @@ export const usePostSuccessModal = () => {
                     // Clean up localStorage
                     localStorage.removeItem('ghost-last-published-post');
                 }
-            } catch (error) {
+            } catch {
                 // Ignore localStorage errors
             }
         };

apps/posts/src/utils/link-helpers.ts

@@ -27,7 +27,7 @@ export const cleanTrackedUrl = (url: string, display = false): string => {
         const urlWithoutProtocol = urlObj.host + (urlObj.pathname === '/' && !urlObj.search ? '' : urlObj.pathname) + (urlObj.search ? urlObj.search : '') + (urlObj.hash ? urlObj.hash : '');
         // remove www. from the start of the URL
         return urlWithoutProtocol.replace(/^www\./, '');
-    } catch (error) {
+    } catch {
         // return the original url if there is an error
         return url;
     }

apps/posts/src/views/PostAnalytics/Growth/growth.tsx

@@ -13,6 +13,7 @@ export const centsToDollars = (value : number) => {
     return Math.round(value / 100);
 };
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 interface postAnalyticsProps {}
 
 const Growth: React.FC<postAnalyticsProps> = () => {