Removed xmlrpc/pingomatic ping service#25799
Conversation
Pingomatic is a legacy blog ping service that is no longer relevant for modern SEO or content distribution. The service was disabled by default and added unnecessary complexity to the codebase.
WalkthroughThe changes comprehensively remove the XML-RPC ping service functionality from the Ghost core application. This includes deleting the service initialization from the boot sequence, removing the entire XMLRPC service implementation module that handled post publication pings to external RPC endpoints, removing the associated configuration flag from the development environment config, and deleting all corresponding unit tests. The removal is complete across all affected files with no fallback mechanisms or migration logic. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
As in Ghost v6.12.0, RPC Ping is removed. More information: TryGhost/Ghost#25799
As in Ghost v6.12.0, RPC Ping is removed. More information: TryGhost/Ghost#25799
Pingomatic is a legacy blog ping service that notified external services when posts were published. It is no longer relevant for modern SEO or content distribution.
The service was disabled by default and added unnecessary complexity to the codebase.
Got some code for us? Awesome 🎊!
Please take a minute to explain the change you're making:
Please check your PR against these items:
We appreciate your contribution! 🙏
Note
Removes the obsolete XML-RPC ping service (Pingomatic) from core and config.
server/services/xmlrpc.jsand its unit testsxmlrpc.listen()and thexmlrpcrequire fromboot.jsprivacy.useRpcPingfromconfig.development.jsonNo other services or boot order affected.
Written by Cursor Bugbot for commit 6214dd7. This will update automatically on new commits. Configure here.