Skip to content

Removed xmlrpc/pingomatic ping service#25799

Merged
sagzy merged 1 commit intoTryGhost:mainfrom
magicpages:feature/remove-pingomatic
Jan 8, 2026
Merged

Removed xmlrpc/pingomatic ping service#25799
sagzy merged 1 commit intoTryGhost:mainfrom
magicpages:feature/remove-pingomatic

Conversation

@betschki
Copy link
Contributor

@betschki betschki commented Jan 7, 2026

Pingomatic is a legacy blog ping service that notified external services when posts were published. It is no longer relevant for modern SEO or content distribution.

The service was disabled by default and added unnecessary complexity to the codebase.

Got some code for us? Awesome 🎊!

Please take a minute to explain the change you're making:

  • Why are you making it?
  • What does it do?
  • Why is this something Ghost users or developers need?

Please check your PR against these items:

  • I've read and followed the Contributor Guide
  • I've explained my change
  • I've written an automated test to prove my change works

We appreciate your contribution! 🙏


Note

Removes the obsolete XML-RPC ping service (Pingomatic) from core and config.

  • Deletes server/services/xmlrpc.js and its unit tests
  • Drops xmlrpc.listen() and the xmlrpc require from boot.js
  • Removes privacy.useRpcPing from config.development.json

No other services or boot order affected.

Written by Cursor Bugbot for commit 6214dd7. This will update automatically on new commits. Configure here.

Pingomatic is a legacy blog ping service that is no longer relevant for
modern SEO or content distribution. The service was disabled by default
and added unnecessary complexity to the codebase.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026

Walkthrough

The changes comprehensively remove the XML-RPC ping service functionality from the Ghost core application. This includes deleting the service initialization from the boot sequence, removing the entire XMLRPC service implementation module that handled post publication pings to external RPC endpoints, removing the associated configuration flag from the development environment config, and deleting all corresponding unit tests. The removal is complete across all affected files with no fallback mechanisms or migration logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Removed xmlrpc/pingomatic ping service' accurately and specifically describes the main change across all modified files.
Description check ✅ Passed The description explains the rationale for removing the obsolete Pingomatic service and its complexity; it directly relates to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 601eaf9 and 6214dd7.

📒 Files selected for processing (4)
  • ghost/core/core/boot.js
  • ghost/core/core/server/services/xmlrpc.js
  • ghost/core/core/shared/config/env/config.development.json
  • ghost/core/test/unit/server/services/xmlrpc.test.js
💤 Files with no reviewable changes (4)
  • ghost/core/core/boot.js
  • ghost/core/core/shared/config/env/config.development.json
  • ghost/core/test/unit/server/services/xmlrpc.test.js
  • ghost/core/core/server/services/xmlrpc.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Unit tests (Node 22.18.0)
  • GitHub Check: Legacy tests (Node 22.18.0, mysql8)
  • GitHub Check: Legacy tests (Node 22.18.0, sqlite3)
  • GitHub Check: Acceptance tests (Node 22.18.0, sqlite3)
  • GitHub Check: Acceptance tests (Node 22.18.0, mysql8)
  • GitHub Check: Ghost-CLI tests
  • GitHub Check: Cursor Bugbot
  • GitHub Check: Build & Push Docker Image

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JohnONolan JohnONolan self-requested a review January 7, 2026 16:24
Copy link
Contributor

@sagzy sagzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sagzy sagzy merged commit 7262fa0 into TryGhost:main Jan 8, 2026
39 checks passed
muratcorlu added a commit to muratcorlu/ghost-docs that referenced this pull request Jan 12, 2026
As in Ghost v6.12.0, RPC Ping is removed. More information:
TryGhost/Ghost#25799
troyciesco pushed a commit to TryGhost/Docs that referenced this pull request Jan 12, 2026
As in Ghost v6.12.0, RPC Ping is removed. More information:
TryGhost/Ghost#25799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments