Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide settings/apps unless apps:true is in config.js #3041

Merged
merged 1 commit into from
Jun 23, 2014
Merged

Hide settings/apps unless apps:true is in config.js #3041

merged 1 commit into from
Jun 23, 2014

Conversation

ErisDS
Copy link
Member

@ErisDS ErisDS commented Jun 23, 2014

fixes #3031

  • Adds an initializer for passing config to the frontend, it's not pretty but it works
  • Forwards the apps route and hides the apps menu item if apps:true is not present in config.js

@ErisDS
Copy link
Member Author

ErisDS commented Jun 23, 2014

This is my first proper ember pr, feedback plz!

@darvelo
Copy link
Contributor

darvelo commented Jun 23, 2014

👏 Bravo!

I'm not certain how window.ENV works so that application.get('config') is populated. It seems window.ENV.config now has an ember meta property attached. Dunno if that's an issue, but yeah, this is great!

jgable
jgable reviewed Jun 23, 2014
View reviewed changes
core/client/routes/settings/apps.js
@@ -1,6 +1,11 @@
import AuthenticatedRoute from 'ghost/routes/authenticated';

var AppsRoute = AuthenticatedRoute.extend({
beforeModel: function () {
if (!this.controllerFor('settings').get('showApps')) {

This comment was marked as abuse.

Sign in to view

@ErisDS
Hide settings/apps unless apps:true is in config.js
bb490e4 
fixes TryGhost#3031

- Adds an initializer for passing config to the frontend, it's not pretty but it works
- Forwards the apps route and hides the apps menu item if apps:true is not present in config.js
@ErisDS
Copy link
Member Author

ErisDS commented Jun 23, 2014

Thanks 👍 Updated :)

@jgable
Copy link
Contributor

jgable commented Jun 23, 2014

Looks good to me 👍

ErisDS added a commit that referenced this pull request Jun 23, 2014
@ErisDS
Merge pull request #3041 from ErisDS/issue-3031
e3e21ff 
Hide settings/apps unless apps:true is in config.js
@ErisDS ErisDS merged commit e3e21ff into TryGhost:master Jun 23, 2014
@ErisDS ErisDS deleted the issue-3031 branch July 1, 2014 06:02
This was referenced Mar 11, 2020
Open
Open
Open
Open
This was referenced Sep 12, 2021
Open
Open
Open
Open
Open
This was referenced Mar 23, 2022
Open
Open
Open
@amgir amgir mentioned this pull request May 13, 2022
Open
@mdno mdno mentioned this pull request May 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ember.js] Settings/Apps pane should only be available if set in config.js
3 participants
@ErisDS @darvelo @jgable