Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding helper for invite status #3326

Merged
merged 1 commit into from
Jul 20, 2014
Merged

Adding helper for invite status #3326

merged 1 commit into from
Jul 20, 2014

Conversation

ErisDS
Copy link
Member

@ErisDS ErisDS commented Jul 19, 2014

Adding helper for invite status
closes #3309, closes #3229

  • adds different message depending on status
  • doesn't delete the new user if the problem was an email error
  • filters the 2 lists based on all statuses

@ErisDS
Copy link
Member Author

ErisDS commented Jul 19, 2014

I've got this mostly done now, except the message doesn't change when the user status changes... I think I've got the completely wrong approach for this bit?

closes TryGhost#3309, refs TryGhost#3229

- adds different message depending on status
- doesn't delete the new user if the problem was an email error
- filters the 2 lists based on all statuses
@ErisDS
Copy link
Member Author

ErisDS commented Jul 20, 2014

This works for now, the horrible 'Email Error' check is symptom of a much larger problem as documented in #3229, I think this is ok as-is for now and we'll resolve the problem with the API later.

ErisDS added a commit that referenced this pull request Jul 20, 2014
Adding helper for invite status
@ErisDS ErisDS merged commit c2f0fd5 into TryGhost:master Jul 20, 2014
@ErisDS ErisDS deleted the issue-3309 branch July 20, 2014 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add error messaging for failed invitations Bug: Invited user is not shown if email fails
1 participant