Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language attribute in config #3890

Closed
wants to merge 3 commits into from
Closed

Add language attribute in config #3890

wants to merge 3 commits into from

Conversation

ericrange
Copy link

There is no language attribute at all for the blog itself (except for the email templates)

There is no language attribute at all for the blog itself (except for the email templates)
@ericrange
Copy link
Author

could be used for seo issues and etc... e.g. "(html lang={{lang}})"

@ericrange
Copy link
Author

if this is merged, i will do the necessary stuff on the casper theme to use this setting

@JohnONolan
Copy link
Member

Language is a user setting, not an environment config. You'll find a full set of planned work around translation is detailed here - which we're certainly looking for some assistance with: #3801

@halfdan
Copy link
Contributor

halfdan commented Aug 27, 2014

Hi @ericrange,
please have a read through our contribution guidelines, especially on how to raise feature requests.

Your PR is unlikely to get merged at this stage as this can easily be handled in a theme without having this config setting. Localisation will be implemented and discussed as part of #3801. It is too early to add language files and translations.

@JohnONolan
Copy link
Member

Snap

@ericrange
Copy link
Author

ah ok, sry^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants