Enable :author as permalink option #4338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes TryGhost#3858 - urlPathForPost is now aware of the author’s slug, allowing for the permalink setting to use :author - Frontend controller only renders posts that have the specified author, if one is given - Extensive tests included
Best PR note ever! 🍩 |
|
There is one slight niggle with this, which is that the validation only happens for one thing or another, however this is following the existing pattern and will be properly resolved by #4322. |
ErisDS
added a commit
that referenced
this pull request
Oct 28, 2014
Enable :author as permalink option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3858
permalink setting to use :author
author, if one is given