Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold] Add the needed table columns for client Oauth. #4785

Closed
wants to merge 1 commit into from
Closed

[Hold] Add the needed table columns for client Oauth. #4785

wants to merge 1 commit into from

Conversation

sgoodwin
Copy link
Contributor

This is to address issue #4174.

@ErisDS ErisDS changed the title Add the needed table columns for client Oauth. [Hold] Add the needed table columns for client Oauth. Jan 10, 2015
@ErisDS
Copy link
Member

ErisDS commented Jan 10, 2015

Hi @sgoodwin thanks for this :) I've added 'HOLD' to the title of this PR as I want to get the next release out before merging it. As soon as we release 0.5.8, there's another schema change issue (#4687) we need to do, and if we merge them together we can do a single version bump & migrating release.

The next release should be happening this coming week, so the hold will only be brief.

@sgoodwin
Copy link
Contributor Author

No problem, there you go.

closes #4174
- Added columns to client table in schema.js
- Bumped database version in default-settings.json
- Updated tests to support new schema version
@jaswilli
Copy link
Contributor

Not at all a comment on the quality of this PR but we should hold this until the features that require it are under development--it's tough to know exactly what database changes are needed until we get into it.

@sgoodwin
Copy link
Contributor Author

That's fair. What can I do to help the other issues along? I have zero ember experience and very little node experience. I'm surprised I figured this much out.

@ErisDS
Copy link
Member

ErisDS commented Jan 12, 2015

One major blocker is that OAuth itself is a fairly tricky subject (let alone the programming around it) and our resident expert @sebgie has been working on other projects. We're also a bit stuck without a way to migrate permissions. If you follow along with meetings / or write-ups you'll see we're planning to shift the team's focus from user-facing features as things are at the moment, towards the developer-facing features like this once we've shipped a few more of the features we're working on.

In short, you can help us out in a number of ways, contributing in any way to the project (testing pull requests, fixing bugs and smaller issues) helps us move faster and get to this stuff sooner ;)

@ErisDS
Copy link
Member

ErisDS commented Aug 28, 2015

Going to close this, as the commit has been pulled into #5706 - a full set of migrations for 004. It will be merged shortly.

@ErisDS ErisDS closed this Aug 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants