RSS: Don't add trailing '/' to post image #4970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixrieseberg
force-pushed
the
iss4888-2
branch
2 times, most recently
from
0322d84 to
089bb9f
Compare
|
|
||
| if (parsed.pathname && parsed.pathname.slice(-1) !== '/') { | ||
| if (path && path.slice(-1) !== '/' && path.indexOf('content/images/') === -1) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Closes TryGhost#4888 We automatically added a trailing slash to all non-absolute paths in RSS, including post images. This fix ensures that trailing slashes aren’t added to absolute paths including ‘content/images/‘.
felixrieseberg
force-pushed
the
iss4888-2
branch
from
089bb9f to
436d2a8
Compare
|
Updated; we're now just getting rid of the trailing slash addition altogether. |
ErisDS
added a commit
that referenced
this pull request
Mar 3, 2015
RSS: Don't add trailing '/' to post image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4888
We automatically added a trailing slash to all non-absolute paths in
RSS, including post images. This fix ensures that trailing slashes
aren’t added to absolute paths including ‘content/images/‘.