[WIP] Use partialIndent hbs option to prevent indent issues #5053
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErisDS
changed the title
|
Closing in favour of #5054 which I am updating to solve both problems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising this here just as a place for discussion - I did attempt to update express-hbs to 0.8.2 so that we could use the
preventIndentcompiler flag, which should fix #4364However for some reason it's not working.
I have tried tracing it through, the problem doesn't seem to be with express-hbs as in handlebars' compiler.js, the option is present in
compileInputbut not inPartialStatement. I don't know the code well enough yet but if anyone fancies taking a look it would be appreciated