Add public API endpoint permission handling #5496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| it('No-auth CANNOT browse non-active users', function (done) { | ||
| UserAPI.browse({status: 'invited'}).then(function () { | ||
| done(new Error('Browse non-active users is not denied without authentication.')); | ||
| }, function (err) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
ErisDS
changed the title
Closed
ErisDS
force-pushed
the
api-public-perms
branch
2 times, most recently
from
b095572
to
684fab5
Compare
Merged
|
@ErisDS I would like to get this PR into master. Do you know what is wrong with the tests? What is needed to remove the WIP tag? |
refs TryGhost#4004, TryGhost#5614 - added new public permission handling functions to permissions - added a new util to handle either public permissions or normal permissions - updated posts, tags and users endpoints to use the new util - added test coverage for the new code
ErisDS
force-pushed
the
api-public-perms
branch
from
684fab5
to
524b247
Compare
ErisDS
changed the title
|
This has been updated to properly handle the uuid behaviour for reads. The Note: this now throws a permissions error where a 404 would have occurred in certain places, tests have been updated accordingly. |
sebgie
added a commit
that referenced
this pull request
Aug 4, 2015
Add public API endpoint permission handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the rule handling for what data public access can retrieve into a singlular place (inside of the permissions system), and ensure that anyone attempting to get access to data they shouldn't gets a permissions error (rather than having their query modified).
With this PR, the get helper would be able to make GET requests to the Post, User & Tag endpoints only. Once we have the client auth in place, we'll be able to use this to provide read only access to the API over HTTP, and to explicitly hard-code in a client ID for the frontend controller & GET helper if we want (useful for logging where requests come from?).
It probably needs a bit more work to refactor out the
handlePermissionsfunctions into a util so the code isn't duplicated 6 times, but it's nearly there :)refs #4004, #5614