Safe post_count for Tags & Users #6091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#6009, TryGhost#5614 - Use the new isPublicContext method to detect whether to add extra clauses to the count - Add count to users
|
Have fixed up the issue that caused MySQL to fail here. All good now. |
sebgie
added a commit
that referenced
this pull request
Nov 19, 2015
Safe post_count for Tags & Users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dirty bare-minimum PR to add
post_countto users and to make sure that post_count is 'safe' in that it only returns public data when a public request is made.Additional work is needed to 1) make it possible to use counts in filters and orders, and 2) change the name from
post_counttocount.postsas well as 3) write proper unit tests for the count plugin.refs #6009, #5614