Fastclick #803
Merged
Fastclick #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #149 Closes #519 - Uses FastClick to speed up click events instead of using Hammer.js tap events
- Changed back button text from "Cancel" to "Back" - Removed box-shadow from back buttons
|
Seems legit. 👍 |
|
Has failed the build |
|
The error appears to be:
Is that just because I didn't put |
|
yes |
|
Above fixed the original fail. I've no idea what the new one is (I don't get it locally (although I do get two image uploading failures which don't seem to be related)). EDIT: it now only fails in node 0.11. Is this acceptable? |
|
The tests should pass, but Travis is being a bit shaky today. I have restarted them. You can also click on the link to restart any broken builds which you don't think should be broken. |
ErisDS
added a commit
that referenced
this pull request
Sep 17, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #149 Closes #519
events