💄 🐷 Test consistency #8199
Merged
💄 🐷 Test consistency #8199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acburdine
reviewed
Mar 20, 2017
core/server/views/default.hbs
Outdated
| @@ -0,0 +1,59 @@ | |||
| <!doctype html> | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kirrg001
reviewed
Mar 20, 2017
There was a problem hiding this comment.
👍
What we also can do is, we add a script in core/test, which will require all the basic test modules we need (should, sinon) and assign as globals. Then we tell mocha to load this script before the tests are executed, here https://github.com/TryGhost/Ghost/blob/master/Gruntfile.js#L147
Each test will have access to the test modules by default.
- change out should.equal for // jshint ignore:line - ensure should is the first require in every test, and ALWAYS require - make sinon the second require, and sandbox the last thing - ALWAYS use sandbox, futureproofs tests against contributors who don't know it - change require formatting
|
Yeah I'd also like to setup a global called |
|
To be clear, I'm not doing those things in this PR! 😁 |
kirrg001
approved these changes
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these changes just make it easy to grok that the test structure is correct. I keep finding files that didn't have should! I'm sure it'll go wrong again, but for now 👍