Moved apps to /services/ & moved individual tests #9187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#9178 - Apps is a service, that allows for the App lifecycle - /server/apps = contains internal apps - /server/services/apps = contains code for managing/handling app life cycle, providing the proxy, etc
- Problem: Not all the tests in apps were unit tests, yet they were treated like they were in Gruntfile.js - Unit tests now live in /test/unit/apps - Route tests now live in /test/functional/routes/apps - Gruntfile.js has been updated to match
- Cover app boot, and determine that the behaviour is correct - This will allow for simplification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #9178
This moves the code that is related to managing the app lifecycle & sandbox into the /services/ folder, so that server/apps only contains internal apps.
It also moves the individual app tests to the /tests/ folder. This is because those tests were assumed to be unit tests, but not all of them were. The subscribers tests were functional route tests. By doing this, we reveal the true level of unit testing of the apps code:
Before:
After:
This makes it clear that the app lifecycle needs deeper unit testing & probably should feed into the discussion about moving one set of tests (either integration or functional).
Note: 2 timezone-related tests are failing on my local machine this morning, which I guess is DST-change related.