Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-webkit v0.11.x support #404

Closed
springmeyer opened this issue Feb 11, 2015 · 4 comments
Closed

node-webkit v0.11.x support #404

springmeyer opened this issue Feb 11, 2015 · 4 comments

Comments

@springmeyer
Copy link
Contributor

Latest node-sqlite3 (v3.0.5) does not compile with node-webkit v0.11.x. This is because NAN is unable to detect the version sufficiently enough to handle it. This regressed in the recent NAN versions that are needed to support node v0.12.x and io.js 1.x. More details at nodejs/nan#238

My understanding from reading nodejs/nan#238 is that the next action is to try building node-sqlite3 against node-webkit (aka. nw.js) v0.12.x and if that can be made to work then document clearly that v0.11.x is NOT SUPPORTED.

@Mithgol
Copy link
Contributor

Mithgol commented Feb 12, 2015

Starting from nodejs/nan#238 (comment) some comments in nodejs/nan#238 seem to imply that current nw.js (v0.12.0-alpha2, I suppose) does not (yet) support current nan and thus @rogerwang has yet to release a newer alpha version of nw.js v0.12.x; only then can we try building anything for it.

Meanwhile it's okay to lose any support for node-webkit v0.11.x (←that's what #403 does). We need the newest nan to support the newest io.js and the newest Node v0.11.x.

@Mithgol
Copy link
Contributor

Mithgol commented Feb 14, 2015

NW.js v0.12.0-alpha3 was released, and it is likely to have nan support already.

Tomorrow (UTC+3) I may try building something from a separate branch. Meanwhile I've updated the list of supported engines.

@zhangtao0x
Copy link

In nan.h we can see as follows from line 175.

/* io.js 1.0 */ if NODE_MODULE_VERSION >= IOJS_1_0_MODULE_VERSION \ || NODE_VERSION_AT_LEAST(0, 11, 15) NAN_INLINE void NanSetCounterFunction(v8::CounterLookupCallback cb) { v8::Isolate::GetCurrent()->SetCounterFunction(cb); }

I guess it's the reason that cause the error.Because from the wrong info we can see

../node_modules/nan/nan.h:200:5: error: ‘SetCounterFunction’ is not a member of ‘v8::V8’ v8::V8::SetCounterFunction(cb); ^

I use the nw 0.11.16 which depends on node v0.11.13,so in nan.h it go into the older v8 conditions,

if I change the NODE_VERSION_AT_LEAST(0,11,15) to (0,11,13) it should work.

I test it on nw v0.11.6, it works! use node-pre-gyp rebuild --runtime=node-webkit --target_arch=ia32 --target=0.11.6

@springmeyer
Copy link
Contributor Author

closing, nothing actionable here. We are currenltly building for node-webkit 0.8 and 0.10 and not 0.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants