Use minimum supported node version for Electron 7 #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kewde any idea why some Travis jobs failed when I ran them from my repo but worked fine from this PR? (using the same commit) For example: It's like the one from my repo was missing xvfb, but can't figure out why, since it should be using the same Travis config |
|
Thank you for the contribution. The appveyor errors are unrelated, will merge after the osx checks are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this change is right, but wondering if this is the reason the CI was failing with Electron 7.
Looks like the minimum supported node version for Electron 7 is Node 8