Skip to content

Conversation

@blubskye
Copy link

Fixes a circular dependency error, and a security vulnerability having to do with tar.

@samuelms1
Copy link

How does this fix the tar vulnerability? I'm not saying it doesn't, but it isn't obvious to me. I can see that node-sqlite3@5.0.2 => node-gyp@3.8.0 => tar@v2.2.2

I see this MR updates node-addon-api which I guess updates node-gyp?

@blubskye
Copy link
Author

blubskye commented Oct 6, 2021

Because the older node version is what was causing the issue. You can try compiling it yourself, and then the audit command actually works. When before it didn't work. It wanted to downgrade the sqlite version for some reason.

@samuelms1
Copy link

I cloned the repo, used node v12.22.6, ran npm i, then ran npm ls, and checked the versions of tar. It was using tar@6.1.11 (not tar@2.2.2 which has the security vulnerability in sqlite@5.0.2).

I think the tar security issue was resolved with #1441. The node-sqlite3@5.0.2 was build in Feb and the fix was in March. I think it just needs to be republished with a new version.

@kewde
Copy link
Collaborator

kewde commented Oct 8, 2021

Thanks eb7708a

@kewde kewde closed this Oct 8, 2021
@blubskye
Copy link
Author

blubskye commented Oct 8, 2021

Yet the person did the same commit that I did, beautiful. At least it's fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants