Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed importing sqlite3#verbose using destructuring syntax #1632

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

mahdi-farnia
Copy link
Contributor

sqlite3#verbose now returns sqlite3 instead of globalThis object when
bound to undefined (void 0). This enables importing verbose in
typescript using import { verbose as sqlite3 } from "sqlite3". Because
typescript automatically converts import statement to
sqlite3_1.default.verbose();.

sqlite3#verbose now returns sqlite3 instead of globalThis object when
bound to undefined (void 0). This enables importing verbose in
typescript using `import { verbose as sqlite3 } from "sqlite3"`. Because
typescript automatically converts import statement to
`sqlite3_1.default.verbose();`.
@daniellockyer daniellockyer changed the title Import sqlite3#verbose using destructuring syntax Fixed importing sqlite3#verbose using destructuring syntax Sep 8, 2022
@daniellockyer daniellockyer merged commit 572f05e into TryGhost:master Sep 8, 2022
@daniellockyer
Copy link
Member

Thank you! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants