-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User profile UI should match designs #2251
Comments
Thanks! I'll break these up into individual tasks and ask Jason about the design bits. |
I would also add:
|
Removing the "needs design" label because this issue mostly needs to be discussed and broken up. |
Yes, since it's kind of immutable I think you're right. I think we should have a confirmation. I'll create an issue for these.
This should be merged to develop now. |
@jgaylor we should discuss what the actual instructions in this issue are for devs. The issue started as a laundry list of small things, so it's a bit of a mess. |
@holmesworcester I suggest Figma is the source of truth for design of the profile, and anything in this ticket be added to the design and annotated with a green dev note. If you agree, this should be moved to "design in progress" and prioritized accordingly. |
This issue covers a few things that will either: a) get resolved the next time we add something to the profile screen, provided we decide to match the latest designs. |
My propositions for small changes that will improve user profile UX:
Long username should be truncated on the sidebar
We could display confirmation that profile image has been uploaded succesfully. This is in case user uploaded e.g image similar to the previous one. It's a good practice to give some clear feedback anyway
(similar to 2.) Info about "Image dimensions must be less than or equal to(...)" should have either a different color of be marked somehow when it appears. I didn't notice it at first when I uploaded an image that is too big.
Clicking on button that opens user profile when user profile is opened should probably hide user profile.
We should unify "closing behavior" for user profile and channel settings menu (the one opened via kebab menu). They look the same but user profile is being closed when user clicks outside it and channel settings are not being closed.
The text was updated successfully, but these errors were encountered: