Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User profile UI should match designs #2251

Closed
EmiM opened this issue Jan 26, 2024 · 8 comments
Closed

User profile UI should match designs #2251

EmiM opened this issue Jan 26, 2024 · 8 comments

Comments

@EmiM
Copy link
Contributor

EmiM commented Jan 26, 2024

My propositions for small changes that will improve user profile UX:

  1. Long username should be truncated on the sidebar
    Image

  2. We could display confirmation that profile image has been uploaded succesfully. This is in case user uploaded e.g image similar to the previous one. It's a good practice to give some clear feedback anyway

  3. (similar to 2.) Info about "Image dimensions must be less than or equal to(...)" should have either a different color of be marked somehow when it appears. I didn't notice it at first when I uploaded an image that is too big.

  4. Clicking on button that opens user profile when user profile is opened should probably hide user profile.

  5. We should unify "closing behavior" for user profile and channel settings menu (the one opened via kebab menu). They look the same but user profile is being closed when user clicks outside it and channel settings are not being closed.

@EmiM EmiM added this to Quiet Jan 26, 2024
@EmiM EmiM converted this from a draft issue Jan 26, 2024
@EmiM EmiM moved this from Backlog - Desktop & Backend to Backlog - Mobile in Quiet Jan 26, 2024
@EmiM EmiM moved this from Backlog - Mobile to Backlog - Desktop & Backend in Quiet Jan 26, 2024
@holmesworcester
Copy link
Contributor

holmesworcester commented Jan 26, 2024

Thanks! I'll break these up into individual tasks and ask Jason about the design bits.

@kingalg
Copy link
Collaborator

kingalg commented Jan 30, 2024

I would also add:

  1. Possibility of going back to the default picture (the way Slack has it).
  2. There is no information about formats we accept - I only managed to upload PNG. At least jpg should be accepted as it's a fairly popular format.
  3. As soon as the user chooses the picture, it's instantly changed everywhere. So if they change their mind after uploading a photo too bad, it's already on everyone's apps. We should add a step when the user approves changes.

@holmesworcester
Copy link
Contributor

Removing the "needs design" label because this issue mostly needs to be discussed and broken up.

@holmesworcester holmesworcester changed the title UX improvements for user profile UX improvements for user profile (truncate usernames, resize images, click away to close) Mar 11, 2024
@holmesworcester
Copy link
Contributor

As soon as the user chooses the picture, it's instantly changed everywhere. So if they change their mind after uploading a photo too bad, it's already on everyone's apps. We should add a step when the user approves changes.
Possibility of going back to the default picture (the way Slack has it).

Yes, since it's kind of immutable I think you're right. I think we should have a confirmation. I'll create an issue for these.

There is no information about formats we accept - I only managed to upload PNG. At least jpg should be accepted as it's a fairly popular format.

This should be merged to develop now.

@holmesworcester holmesworcester changed the title UX improvements for user profile (truncate usernames, resize images, click away to close) User profile UI should match designs May 17, 2024
@holmesworcester holmesworcester removed their assignment May 17, 2024
@holmesworcester holmesworcester moved this from Backlog - Desktop & Backend to Design - Awaiting Internal Feedback in Quiet Dec 4, 2024
@holmesworcester holmesworcester moved this from Design - Awaiting Internal Feedback to Backlog - Desktop & Backend in Quiet Dec 16, 2024
@holmesworcester
Copy link
Contributor

@jgaylor we should discuss what the actual instructions in this issue are for devs. The issue started as a laundry list of small things, so it's a bit of a mess.

@holmesworcester holmesworcester moved this from Backlog - Desktop & Backend to Design Backlog in Quiet Dec 16, 2024
@jgaylor
Copy link
Collaborator

jgaylor commented Dec 16, 2024

@holmesworcester I suggest Figma is the source of truth for design of the profile, and anything in this ticket be added to the design and annotated with a green dev note. If you agree, this should be moved to "design in progress" and prioritized accordingly.

@holmesworcester holmesworcester moved this from Design Backlog to Design In Progress in Quiet Dec 16, 2024
@holmesworcester
Copy link
Contributor

This issue covers a few things that will either:

a) get resolved the next time we add something to the profile screen, provided we decide to match the latest designs.
b) be covered in other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants