-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User should be able to add a custom profile image #615
Comments
We'll use whatever libraries are convenient for cropping, so we just need where this displays, and how it appears in onboarding. (What's the best way to encourage using a profile photo?) Do Discord and Slack make it easy to pick an avatar from a list, if you don't want to add a photo? |
This is great. And we'll use whatever the library offers for cropping, e.g. |
On the frontend, the user profile sidebar panel simply shows the current user's name and profile photo. Clicking on the profile photo brings up a context menu that shows the profile and profile actions (only 'edit profile' for now). Clicking the 'edit profile' action changes the context menu view such that you can edit the profile photo. This commit also adds user profile photos to channel messages. A jdenticon is showed in place of user profile photo if it doesn't exist. On the backend, there is a new shared orbitdb user profiles key/value store. The key/value store maps user public keys with profiles. It uses a custom index so that we can filter invalid entries thoroughly. In state-manager, a new saveUserProfile saga is added which signs the profile data and sends it to the backend.
desktop@2.1.1-alpha.0 It's working. I feel it's more like a draft of a feature than a real feature, and changing things listed in #2251 would certainly help. But there is no reason to keep this issue open as its requirements have been fulfilled. |
Being able to have custom profile images will make things way more comfortable and fun, and it will make the the conversation view in Quiet look a lot better too.
Requirements:
Nice-to-have (break out into separate issues if not done in this round of work:)
When we release this we have to prioritize #614 so that people can't register the name Quiet, set their profile image to the Quiet logo, and spoof system messages.
The text was updated successfully, but these errors were encountered: