Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users can't use jpg's for profile photos #2332

Closed
holmesworcester opened this issue Mar 6, 2024 · 1 comment
Closed

Users can't use jpg's for profile photos #2332

holmesworcester opened this issue Mar 6, 2024 · 1 comment
Assignees
@islathehut
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@holmesworcester
Copy link
Contributor

holmesworcester commented Mar 6, 2024 •
edited
Loading

Steps to reproduce on Ubuntu:

  1. Click profile in bottom left
  2. Click "Edit photo"
  3. Try to select a .jpg

Expected: it works
Actual: JPG isn't visible in file picker.
@holmesworcester holmesworcester converted this from a draft issue Mar 6, 2024
@holmesworcester holmesworcester added bug Something isn't working good first issue Good for newcomers labels Mar 6, 2024
@islathehut islathehut moved this from Backlog - Desktop & Backend to In progress in Quiet Mar 11, 2024
@islathehut islathehut self-assigned this Mar 11, 2024
@islathehut islathehut mentioned this issue Mar 11, 2024
Merged
4 tasks
@islathehut islathehut moved this from In progress to Waiting for review in Quiet Mar 11, 2024
islathehut pushed a commit that referenced this issue Mar 14, 2024
fix: Allow JPEG and GIF images as profile photos #2332 (#2353)
233725f 
* Fixes UserProfileStore and UserProfileContextMenu to allow JPEG and GIF profile photos as well as PNG.
* Updates E2E tests to include JPEG and GIF cases on profile photo tests
* Adds new backend unit tests for img validation
* Adds new npm scripts at the root for conveniently running the desktop app locally instead of having to cd into the desktop package folder and linting all packages at once.
* Adds new npm scripts for local binary compilation and updates E2E tests allow using local binaries
* Adds documentation for new local binary compilation and testing scripts
* Fixes issues I had while running tor tests locally
* Fix the issue with ContextMenuProps having type unknown for the field visible
@islathehut islathehut moved this from Waiting for review to Merged in Quiet Mar 14, 2024
@leblowl leblowl moved this from Merged to Ready for QA in Quiet Apr 4, 2024
@kingalg
Copy link
Collaborator

kingalg commented Apr 11, 2024

Version: 2.2.0-alpha.0

Done.
System: jpg's can be added on Windows, Linux and MacOS and they are visible as avatars on all systems (including iOS and Android).

@kingalg kingalg closed this as completed Apr 11, 2024
@kingalg kingalg moved this from Ready for QA to Done in Quiet Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@islathehut islathehut

Labels
bug Something isn't working good first issue Good for newcomers
Projects
Quiet
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@holmesworcester @islathehut @kingalg