Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji-only messages should have larger font size #519

Open
holmesworcester opened this issue May 19, 2022 · 7 comments
Open

Emoji-only messages should have larger font size #519

holmesworcester opened this issue May 19, 2022 · 7 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@holmesworcester
Copy link
Contributor

holmesworcester commented May 19, 2022

Most messaging apps increase the font size of emoji-only messages because this makes the emoji more visible and fun. We should too!

Use Slack, Signal, or WhatsApp as a reference for emoji size.

Bonus: in-line emojis should have a larger font size too. (Slack seems to render them as images at 22px.)

@holmesworcester holmesworcester moved this to Backlog - Desktop & Backend in Quiet Apr 5, 2023
@holmesworcester holmesworcester added the good first issue Good for newcomers label Apr 7, 2023
@holmesworcester holmesworcester moved this from Backlog - Desktop & Backend to Backlog - Mobile in Quiet Oct 10, 2023
@holmesworcester holmesworcester moved this from Backlog - Mobile to Blocked in Quiet Oct 10, 2023
@holmesworcester holmesworcester moved this from Blocked to Backlog - Desktop & Backend in Quiet Oct 10, 2023
@siepra siepra removed the fun label Jan 11, 2024
@mike-kiss
Copy link
Collaborator

Hi @leblowl and @EmiM 👋 I'm a new contributor getting started with this issue. I have code ready to go, but am running into a weird situation with the pre-commit hooks. When I try to commit, lerna runs and I see my code change from the ' character to the " character and then back to ' again, after which it reports eslint/prettier errors as if it settled on " . I'm assuming this is a config problem on my end, but if you've seen this before, please let me know! Screenshot attached.

Image

@islathehut
Copy link
Collaborator

I added that pre-commit hook and it seems to have issues with linting on files that aren't configured to be linted. I haven't had a chance to look into it but for now if you run the linter with --fix (you can do this at the root by running npm run lint:all) then you can commit with --no-verify. This is just an issue with lint-staged which is only on the pre-commit.

mike-kiss added a commit to mike-kiss/quiet that referenced this issue Mar 25, 2024
mike-kiss added a commit to mike-kiss/quiet that referenced this issue Mar 25, 2024
mike-kiss added a commit to mike-kiss/quiet that referenced this issue Mar 25, 2024
@mike-kiss
Copy link
Collaborator

Thanks! This worked and I've put up a PR. Let me know if I missed anything or if there are needed changes.

@holmesworcester
Copy link
Contributor Author

holmesworcester commented Mar 28, 2024

I think just that issue with tests that Lucas replied to. Thank you for this! Quiet will be 50% more emotive!

mike-kiss added a commit to mike-kiss/quiet that referenced this issue Mar 28, 2024
@leblowl leblowl moved this from Backlog - Desktop & Backend to Merged in Quiet Apr 3, 2024
@leblowl leblowl moved this from Merged to Ready for QA in Quiet Apr 4, 2024
@kingalg
Copy link
Collaborator

kingalg commented Apr 8, 2024

@holmesworcester, it's not in the issue specifications, but was this only for desktops? It's implemented correctly on desktop, but on iOS and Android, the size didn't change.

@holmesworcester
Copy link
Contributor Author

Let's create a new issue for mobile that refers to this issue. Can you do that? For these 'good first issue' issues we are okay with people doing desktop only.

@kingalg
Copy link
Collaborator

kingalg commented Apr 9, 2024

Sure, this is an issue for mobile: Use Slack, Signal, or WhatsApp as a reference for emoji size. And I'm closing this one.

Version: 2.2.0-alpha.0

@kingalg kingalg moved this from Ready for QA to Done in Quiet Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

6 participants