Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(2487): Update github actions for PR gating #2488

Merged
merged 2 commits into from
May 7, 2024

Conversation

islathehut
Copy link
Collaborator

@islathehut islathehut commented Apr 26, 2024

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@islathehut islathehut changed the base branch from develop to isla-test April 26, 2024 17:48
@islathehut islathehut force-pushed the chore-2487-pr-gate-actions branch from 93280f1 to c9340b8 Compare April 26, 2024 18:16
@islathehut islathehut marked this pull request as ready for review April 26, 2024 18:17
@islathehut islathehut changed the title Test exiting early on backend tests when no code present chore(2487): Update github actions for PR gating Apr 26, 2024
@islathehut islathehut force-pushed the chore-2487-pr-gate-actions branch from 347cdae to 157fc70 Compare April 26, 2024 18:28
@islathehut islathehut changed the base branch from isla-test to develop April 26, 2024 18:28
@islathehut
Copy link
Collaborator Author

Implements #2487

@islathehut islathehut force-pushed the chore-2487-pr-gate-actions branch from 1149a2d to 8f1b7cf Compare April 26, 2024 18:39
Copy link
Collaborator

@adrastaea adrastaea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@islathehut islathehut merged commit 0f3c72f into develop May 7, 2024
25 checks passed
@islathehut islathehut deleted the chore-2487-pr-gate-actions branch May 7, 2024 19:14
islathehut pushed a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants