-
Notifications
You must be signed in to change notification settings - Fork 17
Changed the order files get checked for ignoring #38
base: master
Are you sure you want to change the base?
Conversation
This allows the plugin to have greater control on what ESLint gets to see and not.
Changed the order files get checked for ignoring
@TrySound can we please merge this, so this plugin is not broken? |
Same thing goes for https://github.com/airbnb/react-dates which ships with an .eslintrc extending eslint-config-airbnb (which is a dev dependency of theirs). This results in My take is that if the exclude pattern includes As a workaround, I monkey-patched the plugin;
|
@TrySound are you interested in maintaining this anymore? If not, could you transfer it or should we fork it? This has been open almost a year. |
Feel free to migrate it to https://github.com/rollup/plugins monorepo. I will add deprecation to this package then. |
@TrySound I wouldn't know how to do that. I don't do monorepos. If someone can do that, please feel free, but otherwise all I know to do is fork and release a separate package. |
@TrySound I've made a PR at rollup/plugins#575. Please have a look... |
* Initial * Add documentation * Add npm files filter * 1.0.0 * Clear dist folder * Fix documentation * 1.0.1 * Fix build * 1.0.2 * Upgrade eslint * 2.0.0 * Tidy up * Return a name * 2.0.2 * Upgrade to eslint 3 * Add buble back * v3.0.0 * Add lockfile * Move to jest * Build with babel * Upgrade dependencies * Add throwOnError and throwOnWarnings options. Remove throwError option * 4.0.0 * Document config file usage Adds documentation on how to use a config file at project root, mentioned in TrySound/rollup-plugin-eslint#20. * Update config file documentation * Update README.md * Remove node4 support and remove babel * Add prettier * Change api to named export * Upgrade eslint * Clean up gitignore * 5.0.0 * Fix tests warning * PR for optional config string PR to allow a string to be passed for specific config files; primarily to allow different Rollup configs to have different linting rules. * Fixed bug where .eslintrc files were still being used * v5.1.0 * feat: options.fix can change files * feat: add test case * Upgrade dependencies and tests * v6.0.0 * Fix travis * Upgrade to ESLint 6.0.0 * v7.0.0 * Preparing move to rollup/plugins * feat(eslint): fixed TrySound/rollup-plugin-eslint#38 * chore: update after review * chore: lint readme Co-authored-by: Bogdan Chadkin <trysound@yandex.ru> Co-authored-by: Mark Brouch <mark.brouch@gmail.com> Co-authored-by: Levi Roberts <bugs181@gmail.com> Co-authored-by: frankieshen <frankieshen@tencent.com> Co-authored-by: Shenfq <shenfq95@foxmail.com> Co-authored-by: Stéphane Goetz <stephane.goetz@swissquote.ch> Co-authored-by: shellscape <andrew@shellscape.org>
* Initial * Add documentation * Add npm files filter * 1.0.0 * Clear dist folder * Fix documentation * 1.0.1 * Fix build * 1.0.2 * Upgrade eslint * 2.0.0 * Tidy up * Return a name * 2.0.2 * Upgrade to eslint 3 * Add buble back * v3.0.0 * Add lockfile * Move to jest * Build with babel * Upgrade dependencies * Add throwOnError and throwOnWarnings options. Remove throwError option * 4.0.0 * Document config file usage Adds documentation on how to use a config file at project root, mentioned in TrySound/rollup-plugin-eslint#20. * Update config file documentation * Update README.md * Remove node4 support and remove babel * Add prettier * Change api to named export * Upgrade eslint * Clean up gitignore * 5.0.0 * Fix tests warning * PR for optional config string PR to allow a string to be passed for specific config files; primarily to allow different Rollup configs to have different linting rules. * Fixed bug where .eslintrc files were still being used * v5.1.0 * feat: options.fix can change files * feat: add test case * Upgrade dependencies and tests * v6.0.0 * Fix travis * Upgrade to ESLint 6.0.0 * v7.0.0 * Preparing move to rollup/plugins * feat(eslint): fixed TrySound/rollup-plugin-eslint#38 * chore: update after review * chore: lint readme Co-authored-by: Bogdan Chadkin <trysound@yandex.ru> Co-authored-by: Mark Brouch <mark.brouch@gmail.com> Co-authored-by: Levi Roberts <bugs181@gmail.com> Co-authored-by: frankieshen <frankieshen@tencent.com> Co-authored-by: Shenfq <shenfq95@foxmail.com> Co-authored-by: Stéphane Goetz <stephane.goetz@swissquote.ch> Co-authored-by: shellscape <andrew@shellscape.org>
This allows the plugin to have greater control on what ESLint gets to see and not.
For more information see #37