This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
Increase allowed version of peer dep #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rollup is now at v2. From some quick testing, this package works just fine with it.
|
Hi, thanks for headsup. Could you please upgrade rollup in dev dependencies? This will let CI to check new version too. |
|
Sorry, I missed it. Version updated. |
|
Run yarn and commit lockfile please |
|
lol, What a start to the week. So sorry. I was doing everything in the browser. It should be good now. I hope. |
|
New rollup does not work in old node. We do not drop old rollup support but we can just stop testing in old node. Tweak .travis.yml please. |
|
I was about to ask if you'd like me to do that. Done. |
|
But add 10 and 12 please |
|
You got it. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rollup is now at v2. From some quick testing, this package works just fine with it.