-
Notifications
You must be signed in to change notification settings - Fork 42
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reject sourcemap before sending it to uglify (#63)
* Reject sourcemap before sending it to uglify At some point today, our builds started failing with a sourcemap error from this lib. Running the tests here makes it replicable: ``` ● allow to disable source maps DefaultsError: `sourcemap` is not a supported option at DefaultsError.get (eval at <anonymous> (node_modules/uglify-js/tools/node.js:20:1), <anonymous>:71:23) ``` This fixes the error by rejecting the option uglify is now rejecting before the whole thing crashes. * Use delete to mutate options object instead of a new copy * Upgrade serialize-javascript
- Loading branch information
Showing
2 changed files
with
12 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@uorbe001 do you know the reason why uglify started to reject "sourcemap" parameter? I didn't find any relevant changes in uglify
BTW, thanks for fix :)