Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GraphAr parser in importor #277

Closed
wants to merge 0 commits into from
Closed

add GraphAr parser in importor #277

wants to merge 0 commits into from

Conversation

jasinliu
Copy link
Contributor

@jasinliu jasinliu commented Aug 15, 2023 •
edited
Loading

To support GraphAr graph data import.

  1. support vertex column parser.
  2. support edge column parser.
  3. Dockerfile and ci
  4. parse GraphAr graph.yml
  5. add comment
  6. add tests
  7. reject the same edge label with different properties

TODO:

  1. fix ci error
  2. test the data with null type

qishipengqsp
qishipengqsp requested changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@qishipengqsp qishipengqsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他整体问题：

  1. 添加注释
  2. 补充相应的Unit Test和Integrate Test

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
ci/images/tugraph-compile-centos7-Dockerfile Outdated Show resolved Hide resolved
ci/images/tugraph-compile-centos8-Dockerfile Outdated Show resolved Hide resolved
ci/images/tugraph-compile-ubuntu18.04-Dockerfile Outdated Show resolved Hide resolved
src/import/column_parser.h Outdated Show resolved Hide resolved
src/import/column_parser.h Outdated Show resolved Hide resolved
src/import/column_parser.h Outdated Show resolved Hide resolved
src/import/column_parser.h Outdated Show resolved Hide resolved
src/import/import_v3.cpp Outdated Show resolved Hide resolved
qishipengqsp
qishipengqsp reviewed Sep 20, 2023
View reviewed changes
test/integration/test_import_gar.py Outdated Show resolved Hide resolved
test/test_import_gar.cpp Outdated Show resolved Hide resolved
test/test_import_gar.cpp Outdated Show resolved Hide resolved
test/test_import_gar.cpp Outdated Show resolved Hide resolved
qishipengqsp
qishipengqsp reviewed Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@qishipengqsp qishipengqsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外检查一下你所有的auto，auto是调用copy constructor的，尽量用auto&

src/import/graphar_config.h Outdated Show resolved Hide resolved
src/import/graphar_config.h Outdated Show resolved Hide resolved
src/import/graphar_parser.h Outdated Show resolved Hide resolved
src/import/graphar_parser.h Outdated Show resolved Hide resolved
src/import/graphar_parser.h Outdated Show resolved Hide resolved
src/import/graphar_parser.h Outdated Show resolved Hide resolved
src/import/graphar_parser.h Outdated Show resolved Hide resolved
src/import/graphar_parser.h Outdated Show resolved Hide resolved
src/import/import_v3.cpp Outdated Show resolved Hide resolved
test/integration/test_import_gar.py Outdated Show resolved Hide resolved
knightast
knightast reviewed Nov 22, 2023
View reviewed changes
src/import/graphar_config.h Outdated Show resolved Hide resolved
src/import/graphar_config.h Outdated Show resolved Hide resolved
src/import/graphar_parser.cpp Outdated Show resolved Hide resolved
src/import/graphar_config.h Outdated Show resolved Hide resolved
src/import/graphar_parser.cpp Outdated Show resolved Hide resolved
src/import/graphar_parser.cpp Outdated Show resolved Hide resolved
test/resource/data/gar_test/edge_test/movie.graph.yml Outdated Show resolved Hide resolved
@jasinliu jasinliu closed this Jan 25, 2024
@qishipengqsp qishipengqsp reopened this Jan 26, 2024
@jasinliu
Copy link
Contributor Author

It is ready for review.😀 @qishipengqsp @acezen

@qishipengqsp qishipengqsp changed the title GraphAr parser add GraphAr parser in importor Jun 25, 2024
@jasinliu jasinliu closed this Jun 25, 2024
@jasinliu jasinliu mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knightast knightast knightast left review comments

@qishipengqsp qishipengqsp qishipengqsp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasinliu @knightast @qishipengqsp