Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The require-mark of the form can only appear in the end of the label #171

Closed
pengxiaotian opened this issue Jun 17, 2021 · 0 comments · Fixed by #184
Closed

The require-mark of the form can only appear in the end of the label #171

pengxiaotian opened this issue Jun 17, 2021 · 0 comments · Fixed by #184
Labels
effort: low feature request New feature or request

Comments

@pengxiaotian
Copy link
Contributor

This function solves the problem (这个功能解决的问题)

表单的红色星号在标题的开头或结尾应该是可选的

Expected API (期望的 API)

Form Props：
名称： require-mark-placement
类型： 'start' | 'end'
默认值：'end'
描述： 必填星号在标签上的位置
@pengxiaotian pengxiaotian changed the title 表单的红色星号现在只能出现在标题结尾 The require-mark of the form can only appear in the end of the label Jun 17, 2021
@07akioni 07akioni added feature request New feature or request effort: low labels Jun 17, 2021
doom-9-zz pushed a commit to doom-9-zz/naive-ui that referenced this issue Jun 18, 2021
@doom-9
feat(form): support require-mark-placement(tusen-ai#171)
0627777
doom-9-zz pushed a commit to doom-9-zz/naive-ui that referenced this issue Jun 18, 2021
@doom-9
feat(form): support require-mark-placement(tusen-ai#171)
c03871d
doom-9-zz pushed a commit to doom-9-zz/naive-ui that referenced this issue Jun 18, 2021
@doom-9
Revert "feat(form): support require-mark-placement(tusen-ai#171)"
f9729c8 
This reverts commit 0627777.
doom-9-zz pushed a commit to doom-9-zz/naive-ui that referenced this issue Jun 18, 2021
@doom-9
feat(form): support require-mark-placement(tusen-ai#171)
81e9f78
doom-9-zz pushed a commit to doom-9-zz/naive-ui that referenced this issue Jun 18, 2021
@doom-9
feat(form): support require-mark-placement(tusen-ai#171)
142ffa2
doom-9-zz pushed a commit to doom-9-zz/naive-ui that referenced this issue Jun 18, 2021
@doom-9
feat(form): support require-mark-placement(tusen-ai#171)
cedb92f
doom-9-zz pushed a commit to doom-9-zz/naive-ui that referenced this issue Jun 18, 2021
@doom-9
feat(form): support require-mark-placement(tusen-ai#171)
1a44fad
07akioni added a commit that referenced this issue Jun 18, 2021
@doom-9-zz @07akioni
feat(form): require-mark support left and right (#184)
107dc13 
* feat(form): support require-mark-placement(#171)

* feat(form): support require-mark-placement(#171)

* feat(form): support require-mark-placement(#171)

* feat(form): support require-mark-placement(#171)

* feat(form): support require-mark-placement(#171)

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: 07akioni <07akioni2@gmail.com>
@07akioni 07akioni linked a pull request Jun 18, 2021 that will close this issue
feat(form): support require-mark-placement(#171) #184
Merged
07akioni pushed a commit that referenced this issue Jul 1, 2021
@doom-9-zz
feat(image): add alt prop (#335)
322bf2c 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* feat(input): add alt prop

* feat(input): add alt prop

* feat(input): add alt prop
07akioni pushed a commit that referenced this issue Jul 3, 2021
@doom-9-zz
feat:(image): add img-props prop (#349)
4191aae 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* feat:(image): add test

* feat:(image): add test

* WIP

* WIP

* feat(image): add imgProps prop and add test

* feat(image): add imgProps type
07akioni pushed a commit that referenced this issue Jul 5, 2021
@doom-9-zz
feat:(carousel): add dot-position prop (#366)
85c0bae 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* feat:(n-carousel): add dotPosition prop

* feat:(n-carousel): add test and fix code

* feat:(n-carousel): fix code

* feat:(n-carousel): fix code

* feat:(n-carousel): fix code and remove console
07akioni pushed a commit that referenced this issue Jul 9, 2021
@doom-9-zz
feat(rate): add allow-half prop (#426)
675cee2 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* feat(n-rate): add allow-half prop

* feat(rate): add docs and fix code

* feat(rate): fix code

* feat(rate): fix doc

* feat(rate): fix doc
07akioni pushed a commit that referenced this issue Jul 9, 2021
@doom-9-zz
feat(carousel): add arrow prop (#451)
b3a3497 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* WIP

* feat(carousel): add arrow prop

* feat(carousel): fix code

* feat(carousel): fix code and add test

* feat(carousel): fix style

* feat(carousel): add test
07akioni pushed a commit that referenced this issue Jul 12, 2021
@doom-9-zz
feat(rate): add disabled prop and clean code (#474)
b4a1ab6 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* feat(rate): add disabled prop and clean code

* feat(rate): add test

* feat(rate): fix code

* feat(rate): fix code

* feat(rate): fix test
07akioni pushed a commit that referenced this issue Jul 16, 2021
@doom-9-zz
feat(checkbox-group): add min max prop (#491)
cb929ff 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* feat(checkboxGroup): add min max prop   WIP

* feat(checkboxGroup): add min max prop WIP

* feat(checkboxGroup): add min max prop

* Update CHANGELOG.zh-CN.md

* Update CheckboxGroup.tsx

* feat(checkboxGroup): fix code

* Update Checkbox.spec.ts

* feat(checkboxGroup): fix code
07akioni added a commit that referenced this issue Aug 10, 2021
@doom-9-zz @07akioni
fix(rate): half star overlays star background in dark mode (#818)
427003d 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* Update index.cssr.ts

* feat: fix code

Co-authored-by: 07akioni <07akioni2@gmail.com>
07akioni pushed a commit that referenced this issue Aug 15, 2021
@doom-9-zz
feat(message-provider): add placement prop (#851)
3d7f96d 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* feat(message provider): add placement prop(wip)

* feat(message provider): add placement prop

* feat: add demo

* feat: fix demo code

* feat: fix code

* feat: fix code

* Update CHANGELOG.en-US.md

* feat: fix style code
07akioni pushed a commit that referenced this issue Sep 2, 2021
@doom-9-zz
feat(data-table): support shiftKey check (#1026)
a715dfd 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* feat(data-table): wip

* feat: fix code

* feat: fix code

* feat: update changelog

* feat: update changelog

* feat: fix code

* feat: fix code
07akioni pushed a commit that referenced this issue Sep 12, 2021
@doom-9-zz
feat(page-header): support rtl (#1154)
d4ae009 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* feat(page-header): support rtl

* add en demo

* fix code

* fix code

* fix code
07akioni pushed a commit that referenced this issue Oct 6, 2021
@doom-9-zz
feat(date-picker): support month type (#1202)
3ea326e 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* feat(date-picker): wip

* feat(date-picker): wip

* feat(date-picker): support VirtualList

* wip

* 添加 NScrollbar

* Update use-calendar.ts

* changelog

* 抽取公共代码

* 完善代码
rhengles pushed a commit to arijs/naive-ui that referenced this issue Oct 20, 2021
@doom-9-zz @rhengles
feat(message-provider): add placement prop (tusen-ai#851)
060a4f2 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(tusen-ai#171)

* Revert "feat(form): support require-mark-placement(tusen-ai#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* feat(message provider): add placement prop(wip)

* feat(message provider): add placement prop

* feat: add demo

* feat: fix demo code

* feat: fix code

* feat: fix code

* Update CHANGELOG.en-US.md

* feat: fix style code
07akioni added a commit that referenced this issue Nov 14, 2021
@doom-9-zz @songjianet
@XieZongChen @07akioni @Volankey
feat(date-picker): support year type (#1297)
80dd6d6 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* test(dialog): Update dialog component test (#1404)

* test(data-table): update test (#1411)

* fix

* Feat(date picker) support year type

* format code

* 修正代码

* 修正代码

* 去掉多余代码

* 去掉无用代码

* 修正代码

* 修改类型

* 修正代码

* Update src/date-picker/src/DatePicker.tsx

Co-authored-by: Mr.Bai <935196116@qq.com>

* Update src/date-picker/src/DatePicker.tsx

* 修正代码

* checkbox:  简化代码

* add padding-bottom

* changelog

* Update Checkbox.tsx

Co-authored-by: songjianet <1778651752@qq.com>
Co-authored-by: XieZongChen <46394163+amadeus711@users.noreply.github.com>
Co-authored-by: 07akioni <07akioni2@gmail.com>
Co-authored-by: Mr.Bai <935196116@qq.com>
07akioni added a commit that referenced this issue Feb 3, 2022
@doom-9-zz @songjianet
@XieZongChen @07akioni
feat(dynamic-input): add sort button (#2139)
1803e40 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* test(dialog): Update dialog component test (#1404)

* test(data-table): update test (#1411)

* fix

* feat

* feat

* feat

* changelog

* test

* changelog

* fix

* feat

* fix

* feat

* changelog

* Update DynamicInput.tsx

* Update CHANGELOG.zh-CN.md

Co-authored-by: songjianet <1778651752@qq.com>
Co-authored-by: XieZongChen <46394163+amadeus711@users.noreply.github.com>
Co-authored-by: 07akioni <07akioni2@gmail.com>
jaulz pushed a commit to jaulz/naive-ui that referenced this issue Mar 11, 2022
@doom-9-zz @songjianet
@XieZongChen @07akioni
feat(dynamic-input): add sort button (tusen-ai#2139)
c7d8277 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(tusen-ai#171)

* Revert "feat(form): support require-mark-placement(tusen-ai#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* test(dialog): Update dialog component test (tusen-ai#1404)

* test(data-table): update test (tusen-ai#1411)

* fix

* feat

* feat

* feat

* changelog

* test

* changelog

* fix

* feat

* fix

* feat

* changelog

* Update DynamicInput.tsx

* Update CHANGELOG.zh-CN.md

Co-authored-by: songjianet <1778651752@qq.com>
Co-authored-by: XieZongChen <46394163+amadeus711@users.noreply.github.com>
Co-authored-by: 07akioni <07akioni2@gmail.com>
07akioni added a commit that referenced this issue Jun 19, 2022
@doom-9-zz @songjianet
@XieZongChen @07akioni
feat(image): add lazy prop (#3096)
60a2d7a 
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* test(dialog): Update dialog component test (#1404)

* test(data-table): update test (#1411)

* fix

* 图片懒加载

* 添加debug

* 完善

* 添加demo文件

* changelog

* 更新DOM后才开始执行

Co-authored-by: songjianet <1778651752@qq.com>
Co-authored-by: XieZongChen <46394163+amadeus711@users.noreply.github.com>
Co-authored-by: 07akioni <07akioni2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(form): support require-mark-placement(#171) doom-9-zz/naive-ui
2 participants
@07akioni @pengxiaotian