Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dialog): Update dialog component test #1404

Merged
merged 2 commits into from
Oct 21, 2021
Merged

test(dialog): Update dialog component test #1404

merged 2 commits into from
Oct 21, 2021

Conversation

songjianet
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/EDxZukC4LDGqk7zdMSDa5sxCUDJg
✅ Preview: https://naive-ui-git-fork-songjianet-main-dialog-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1404 (65c0253) into main (7b3b1c9) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1404      +/-   ##
==========================================
+ Coverage   52.79%   52.81%   +0.02%     
==========================================
  Files         533      533              
  Lines       13316    13328      +12     
  Branches     3799     3804       +5     
==========================================
+ Hits         7030     7039       +9     
- Misses       5163     5170       +7     
+ Partials     1123     1119       -4     
Impacted Files Coverage Δ
src/tabs/src/Tab.tsx 30.76% <0.00%> (-9.24%) ⬇️
src/upload/src/UploadTrigger.tsx 75.00% <0.00%> (-1.67%) ⬇️
src/date-picker/src/DatePicker.tsx 60.82% <0.00%> (-0.57%) ⬇️
src/upload/src/Upload.tsx 71.63% <0.00%> (-0.40%) ⬇️
src/tabs/src/interface.ts 100.00% <0.00%> (ø)
src/upload/src/interface.ts 100.00% <0.00%> (ø)
src/tabs/src/Tabs.tsx 44.51% <0.00%> (+0.34%) ⬆️
src/dialog/src/Dialog.tsx 74.41% <0.00%> (+20.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3b1c9...65c0253. Read the comment docs.

src/dialog/tests/Dialog.spec.tsx Outdated Show resolved Hide resolved
src/dialog/tests/Dialog.spec.tsx Outdated Show resolved Hide resolved
@XieZongChen XieZongChen merged commit 15114a1 into tusen-ai:main Oct 21, 2021
07akioni pushed a commit that referenced this pull request Oct 21, 2021
* feat(color-picker): add `color-preview`

* docs(color-picker): add docs

* docs(color-picker): replace symbols

* feat(color-picker): `color-picker-swatches` support keyboard selection

* fix: guarantee test pass

* chore: use `toUpperCase`

* feat(color-picker): add `show-preview` prop

* chore(color-picker): public color convert function

* chore: keep uppercase

* docs(color-picker): document with color preview

* chore(color-picker): correct the variable name

* docs(color-picker): update docs

* refactor(tabs): on-before-leave prop

* fix(tabs): typo

* fix(upload): file can't be removed when file count limit is reached, closes #1401

* 2.19.11

* test(dialog): Update dialog component test (#1404)

* test(data-table): update test (#1411)

* chore: correct prop

Co-authored-by: 张乐聪 <zhanglecong@bytedance.com>
Co-authored-by: songjianet <1778651752@qq.com>
Co-authored-by: XieZongChen <46394163+amadeus711@users.noreply.github.com>
07akioni added a commit that referenced this pull request Oct 26, 2021
* refactor(tabs): on-before-leave prop

* fix(tabs): typo

* fix(upload): file can't be removed when file count limit is reached, closes #1401

* 2.19.11

* test(dialog): Update dialog component test (#1404)

* test(data-table): update test (#1411)

* feat(data-table): restructure virtual-scroll

* feat(data-table): optimization

* feat: optimization

* feat(data-table): optimization expanded

* feat: optimization

* feat: optimization

* feat: optimization

* feat: optimization

* feat: optimization

* feat: add change log

* Update src/data-table/src/TableParts/Body.tsx

Co-authored-by: 张乐聪 <zhanglecong@bytedance.com>
Co-authored-by: songjianet <1778651752@qq.com>
Co-authored-by: 07akioni <07akioni2@gmail.com>
07akioni pushed a commit that referenced this pull request Oct 27, 2021
* refactor(tabs): on-before-leave prop

* fix(tabs): typo

* fix(upload): file can't be removed when file count limit is reached, closes #1401

* 2.19.11

* test(dialog): Update dialog component test (#1404)

* test(data-table): update test (#1411)

* feat(input): n-input add categories supported by const slots

Co-authored-by: 张乐聪 <zhanglecong@bytedance.com>
Co-authored-by: songjianet <1778651752@qq.com>
07akioni added a commit that referenced this pull request Oct 31, 2021
…-keys` prop changes in `remote` mode (#1429)

* test(dialog): Update dialog component test (#1404)

* test(data-table): update test (#1411)

* feat(tree): n-tree's on-load prop is triggered when the expanded-keys prop changes in remote mode

* feat: optimization

* feat: optimization

* feat: optimization

* feat: optimization

* Update src/tree/src/Tree.tsx

Co-authored-by: songjianet <1778651752@qq.com>
Co-authored-by: 07akioni <07akioni2@gmail.com>
07akioni added a commit that referenced this pull request Nov 14, 2021
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* test(dialog): Update dialog component test (#1404)

* test(data-table): update test (#1411)

* fix

* Feat(date picker) support year type

* format code

* 修正代码

* 修正代码

* 去掉多余代码

* 去掉无用代码

* 修正代码

* 修改类型

* 修正代码

* Update src/date-picker/src/DatePicker.tsx

Co-authored-by: Mr.Bai <935196116@qq.com>

* Update src/date-picker/src/DatePicker.tsx

* 修正代码

* checkbox:  简化代码

* add padding-bottom

* changelog

* Update Checkbox.tsx

Co-authored-by: songjianet <1778651752@qq.com>
Co-authored-by: XieZongChen <46394163+amadeus711@users.noreply.github.com>
Co-authored-by: 07akioni <07akioni2@gmail.com>
Co-authored-by: Mr.Bai <935196116@qq.com>
07akioni added a commit that referenced this pull request Feb 3, 2022
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* test(dialog): Update dialog component test (#1404)

* test(data-table): update test (#1411)

* fix

* feat

* feat

* feat

* changelog

* test

* changelog

* fix

* feat

* fix

* feat

* changelog

* Update DynamicInput.tsx

* Update CHANGELOG.zh-CN.md

Co-authored-by: songjianet <1778651752@qq.com>
Co-authored-by: XieZongChen <46394163+amadeus711@users.noreply.github.com>
Co-authored-by: 07akioni <07akioni2@gmail.com>
jaulz pushed a commit to jaulz/naive-ui that referenced this pull request Mar 11, 2022
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(tusen-ai#171)

* Revert "feat(form): support require-mark-placement(tusen-ai#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* test(dialog): Update dialog component test (tusen-ai#1404)

* test(data-table): update test (tusen-ai#1411)

* fix

* feat

* feat

* feat

* changelog

* test

* changelog

* fix

* feat

* fix

* feat

* changelog

* Update DynamicInput.tsx

* Update CHANGELOG.zh-CN.md

Co-authored-by: songjianet <1778651752@qq.com>
Co-authored-by: XieZongChen <46394163+amadeus711@users.noreply.github.com>
Co-authored-by: 07akioni <07akioni2@gmail.com>
07akioni added a commit that referenced this pull request Jun 19, 2022
* feat:n-input Support hidden password

* feat(form): support require-mark-placement(#171)

* Revert "feat(form): support require-mark-placement(#171)"

This reverts commit 0627777.

* Revert "feat:n-input Support hidden password"

This reverts commit ea64917.

* test(dialog): Update dialog component test (#1404)

* test(data-table): update test (#1411)

* fix

* 图片懒加载

* 添加debug

* 完善

* 添加demo文件

* changelog

* 更新DOM后才开始执行

Co-authored-by: songjianet <1778651752@qq.com>
Co-authored-by: XieZongChen <46394163+amadeus711@users.noreply.github.com>
Co-authored-by: 07akioni <07akioni2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants