Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-table): restructure virtual-scroll #1295

Merged
merged 22 commits into from
Oct 26, 2021
Merged

feat(data-table): restructure virtual-scroll #1295

merged 22 commits into from
Oct 26, 2021

Conversation

XieZongChen
Copy link
Collaborator

@XieZongChen XieZongChen commented Oct 8, 2021

No description provided.

@vercel
Copy link

vercel bot commented Oct 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/8uZbxhaQnTpHQhRTEzr8mTk2SUFt
✅ Preview: https://naive-ui-git-fork-amadeus711-feat-ndatatable-vi-227b79-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #1295 (204e286) into main (2efa2f2) will increase coverage by 0.01%.
The diff coverage is 82.66%.

❗ Current head 204e286 differs from pull request most recent head 8f692d4. Consider uploading reports for the commit 8f692d4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
+ Coverage   52.90%   52.92%   +0.01%     
==========================================
  Files         536      534       -2     
  Lines       13368    13367       -1     
  Branches     3822     3817       -5     
==========================================
+ Hits         7072     7074       +2     
+ Misses       5167     5165       -2     
+ Partials     1129     1128       -1     
Impacted Files Coverage Δ
src/data-table/src/TableParts/Body.tsx 66.48% <82.66%> (+0.94%) ⬆️
src/date-picker/src/panel/month.tsx 40.62% <0.00%> (-4.21%) ⬇️
src/date-picker/src/panel/use-panel-common.ts 38.29% <0.00%> (-3.71%) ⬇️
src/date-picker/src/panel/use-calendar.ts 35.64% <0.00%> (-0.73%) ⬇️
src/date-picker/src/panel/use-dual-calendar.ts 31.86% <0.00%> (-0.54%) ⬇️
src/locales/common/idID.ts
src/locales/date/idID.ts
src/date-picker/src/panel/date.tsx 53.57% <0.00%> (+1.57%) ⬆️
src/date-picker/src/panel/datetime.tsx 53.57% <0.00%> (+1.57%) ⬆️
src/date-picker/src/panel/daterange.tsx 48.57% <0.00%> (+1.69%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2efa2f2...8f692d4. Read the comment docs.

src/data-table/src/TableParts/Body.tsx Outdated Show resolved Hide resolved
src/data-table/src/TableParts/Body.tsx Outdated Show resolved Hide resolved
src/data-table/src/TableParts/Body.tsx Outdated Show resolved Hide resolved
src/data-table/src/TableParts/Body.tsx Outdated Show resolved Hide resolved
src/data-table/src/interface.ts Outdated Show resolved Hide resolved
src/data-table/src/TableParts/Body.tsx Outdated Show resolved Hide resolved
src/data-table/src/TableParts/Body.tsx Outdated Show resolved Hide resolved
src/data-table/src/TableParts/Body.tsx Outdated Show resolved Hide resolved
src/data-table/src/TableParts/Body.tsx Outdated Show resolved Hide resolved
@XieZongChen XieZongChen changed the title Draft: feat(data-table): restructure virtual-scroll feat(data-table): restructure virtual-scroll Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants