Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input-number doesn't change with +/- buttons if you delete its content at least once #251

Closed
wc-matteo opened this issue Jun 22, 2021 · 0 comments · Fixed by #259
Closed

input-number doesn't change with +/- buttons if you delete its content at least once #251

wc-matteo opened this issue Jun 22, 2021 · 0 comments · Fixed by #259
Assignees
@07akioni
Labels
bug Something isn't working

Comments

@wc-matteo
Copy link

wc-matteo commented Jun 22, 2021 •
edited
Loading

TuSimple/naive-ui version (版本)

2.13.0

Vue version (Vue 版本)

3.1.2

Browser and its version (浏览器及其版本)

Chrome 91.0.4472.106

System and its version (系统及其版本)

Windows 10

Node version (Node 版本)

Reappearance link (重现链接)

https://codesandbox.io/s/0gse4

Reappearance steps (重现步骤)

Press + in the min field (notice it increments)
Delete the value from the field (backspace)
Press + again

Expected results (期望的结果)

The value increments like the first time

Actual results (实际的结果)

The value doesn't increment. Nothing happens

Remarks (补充说明)
doom-9-zz pushed a commit to doom-9-zz/naive-ui that referenced this issue Jun 23, 2021
@doom-9
fix(input-number): doesn't change with /- buttons if you delete its c…
d62d4ab 
…ontent at least once(tusen-ai#251)
@doom-9-zz doom-9-zz mentioned this issue Jun 23, 2021
Closed
@07akioni 07akioni added the bug Something isn't working label Jun 23, 2021
@07akioni 07akioni self-assigned this Jun 23, 2021
07akioni added a commit that referenced this issue Jun 23, 2021
@07akioni
fix(input-number): many fixes
a91dd59 
- Fix `n-input-number` lacks `on-update-value` prop.
- Fix `n-input-number`'s value can't be null.
- Fix `n-input-number`'s button doesn't work after value is cleared, closes [#251](#251).
- `n-input-number` will focus directly, closes [#244](#244).
@07akioni 07akioni mentioned this issue Jun 23, 2021
Merged
07akioni added a commit that referenced this issue Jun 23, 2021
@07akioni
fix(input-number): many fixes (#259)
4ebecee 
* fix(input-number): many fixes

- Fix `n-input-number` lacks `on-update-value` prop.
- Fix `n-input-number`'s value can't be null.
- Fix `n-input-number`'s button doesn't work after value is cleared, closes [#251](#251).
- `n-input-number` will focus directly, closes [#244](#244).

* docs(input-number): fixes

* docs
@wc-matteo wc-matteo changed the title input-number doesn't change with /- buttons if you delete its content at least once input-number doesn't change with +/- buttons if you delete its content at least once Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@07akioni 07akioni

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(input-number): many fixes tusen-ai/naive-ui
2 participants
@wc-matteo @07akioni