Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-number): many fixes #259

Merged
merged 3 commits into from
Jun 23, 2021
Merged

fix(input-number): many fixes #259

merged 3 commits into from
Jun 23, 2021

Conversation

07akioni
Copy link
Collaborator

  • Fix n-input-number lacks on-update-value prop.
  • Fix n-input-number's value can't be null.
  • Fix n-input-number's button doesn't work after value is cleared, closes #251.
  • n-input-number will focus directly, closes #244.

- Fix `n-input-number` lacks `on-update-value` prop.
- Fix `n-input-number`'s value can't be null.
- Fix `n-input-number`'s button doesn't work after value is cleared, closes [#251](#251).
- `n-input-number` will focus directly, closes [#244](#244).
@vercel
Copy link

vercel bot commented Jun 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/9Wg1vfYEduqp4LPxkQFgTu7V8QMR
✅ Preview: https://naive-ui-git-fix-input-number-tusimple.vercel.app

@07akioni 07akioni temporarily deployed to test June 23, 2021 05:22 Inactive
@07akioni 07akioni temporarily deployed to test June 23, 2021 05:22 Inactive
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #259 (a91dd59) into main (fd23a30) will increase coverage by 0.57%.
The diff coverage is 63.63%.

❗ Current head a91dd59 differs from pull request most recent head 0d21a73. Consider uploading reports for the commit 0d21a73 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   31.35%   31.92%   +0.57%     
==========================================
  Files         505      505              
  Lines       12001    12005       +4     
  Branches     3264     3266       +2     
==========================================
+ Hits         3763     3833      +70     
+ Misses       7546     7451      -95     
- Partials      692      721      +29     
Impacted Files Coverage Δ
src/input-number/src/InputNumber.tsx 53.17% <63.63%> (+15.90%) ⬆️
src/_mixins/use-form-item.ts 57.69% <0.00%> (ø)
src/input/src/Input.tsx 31.90% <0.00%> (+11.51%) ⬆️
src/input-number/src/utils.ts 73.33% <0.00%> (+40.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd23a30...0d21a73. Read the comment docs.

@07akioni 07akioni temporarily deployed to test June 23, 2021 05:35 Inactive
@07akioni 07akioni temporarily deployed to test June 23, 2021 05:35 Inactive
@07akioni 07akioni merged commit 4ebecee into main Jun 23, 2021
@07akioni 07akioni deleted the fix-input-number branch June 23, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant