Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Exchange] Add Bitmart exchange #42

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

adeacetis
Copy link
Collaborator

@adeacetis adeacetis commented Oct 13, 2023

This PR would add Bitmart Exchange for aggr-server.

Notes:

  • Recovering trades when the server fails is limited to the latest 50 trades. We could circumvent this issue by downloading all the 1m candles from the kLines endpoint. This should be part of a larger discussion as it could be needed in other exchanges as well.

To-do:

  • Double-check the RecentTrades API for futures

Implementation with AGGR-UI. We can note the gap in data.
image

Many thanks to @lmvdz for his implementation.

@adeacetis adeacetis requested a review from Tucsky October 13, 2023 12:34
@adeacetis adeacetis modified the milestones: 1.2.0, 1.1.0 Oct 13, 2023
@adeacetis adeacetis force-pushed the feature/add-bitmart-exchange branch 2 times, most recently from a842402 to 54d7a13 Compare October 13, 2023 13:16
@adeacetis adeacetis force-pushed the feature/add-bitmart-exchange branch from 54d7a13 to cb8dda2 Compare October 14, 2023 00:25
Base automatically changed from dev to master March 6, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants