-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.1.0 #43
Draft
adeacetis
wants to merge
19
commits into
master
Choose a base branch
from
release/1.1.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Release 1.1.0 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add formatted files
Removed exchange id argument as same info could be extracted from the trade object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This Pull Request marks a significant milestone in our project's version control history. Up until now, our team has not been following versioning best practices correctly, leading to a situation where the initial commit version serves as our baseline. This update represents a concerted effort to catch up and establish a proper versioning system for our project.
Changes
Version Bump:
We have incrementally updated the project version to bring it in line with where it should be based on the work that has been done since the initial commit.
Revised Versioning Strategy:
Going forward, we are instituting a more structured versioning strategy to ensure that our project versions accurately reflect the progress and changes made over time. This strategy will encompass semantic versioning (SemVer) principles to better convey the nature of changes.
Documentation and Changelog Updates (in progress):
The changelog and documentation have been updated to reflect the historical changes that were previously unaccounted for.
Code Clean-Up: We've taken this opportunity to address some code quality issues that have accumulated since the initial commit, making our codebase more maintainable and robust.
Why This Matters
Clarity: Proper versioning is essential for providing clarity and context about the state and history of the project. This clarity is crucial for both our team and any collaborators or users.
Maintenance: Structured versioning simplifies maintenance, as it allows us to identify which features were added, modified, or deprecated in each release.
Collaboration: With a reliable versioning system, collaboration with external developers, third-party integrations, and other stakeholders becomes more efficient and less error-prone.
Let's use this as a turning point in our project's version control history to maintain transparency, enhance collaboration, and continue delivering value to our users.