Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altitude-dependent aerodynamic coefficients #83

Closed
DominicDirkx opened this issue Nov 8, 2016 · 7 comments
Closed

Altitude-dependent aerodynamic coefficients #83

DominicDirkx opened this issue Nov 8, 2016 · 7 comments

Comments

@DominicDirkx
Copy link
Member

I've added some code for altitude-dependent aerodynamic coefficients, but have not yet added a unit test

(https://github.com/DominicDirkx/tudat/tree/AltitudeIndependentVariableForAerodynamics)

Aleix, since you're going to be using this code anyway, and applying an altitude-dependent aerodynamics model, could you add a unit test when you have your code running? Y

ou could simply use a propagation that you will be doing anyway as code, save the aerodynamic coefficients and altitude as dependent variables (http://tudat.tudelft.nl/projects/tudat/wiki/Propagation_setup#Saving-output-of-the-simulation), and then compare these two values to see if the altitude is being properly used to compute the aerodynamic coefficients. Let me know.

@aleixpinardell
Copy link
Member

I can't find where it is... I only see these variables:

enum AerodynamicCoefficientsIndependentVariables
{
    mach_number_dependent = 0,
    angle_of_attack_dependent = 1,
    angle_of_sideslip_dependent = 2,
    undefined_independent_variable = 3
};

@DominicDirkx
Copy link
Member Author

Hi Aleix,

I guess you are taking this from the master branch? For the particular branch, the file is modified:

https://github.com/DominicDirkx/tudat/blob/AltitudeIndependentVariableForAerodynamics/Tudat/Astrodynamics/Aerodynamics/aerodynamicCoefficientInterface.h

You have to checkout this branch on your machine, then you will see the changes. From the terminal, the commands are:

Step 1: From your project repository, check out a new branch and test the changes.

git checkout -b DominicDirkx-AltitudeIndependentVariableForAerodynamics master
git pull https://github.com/DominicDirkx/tudat.git AltitudeIndependentVariableForAerodynamics

@DominicDirkx
Copy link
Member Author

Hi Aleix,

I've changed a few things in the TabulatedAerodynamicCoefficientSettings constructor (createFlightConditions.h). For aerodynamic data with only 1 independent variable, you can now use the template specialization TabulatedAerodynamicCoefficientSettings< 1 > (so call make_shared< TabulatedAerodynamicCoefficientSettings< 1 > >( ... constructor arguments here .... ). There is a constructor with and without the option to set moment coefficients.

Note that you need to provide interpolation settings (object of class InterpolatorSettings in createInterpolator.h) to define how the discrete data is to be interpolated to a continuous database.

Let me know if you run into any issues when setting up the unit test for the altitude-dependence (which will also automatically test the TabulatedAerodynamicCoefficientSettings< 1 > ).

@aleixpinardell
Copy link
Member

aleixpinardell commented Nov 15, 2016

I am getting this runtime error:

libc++abi.dylib: terminating with uncaught exception of type std::runtime_error: Error, do not recognize aerodynamic coefficient settings for Rocket

Apparently, the coefficientSettings->getAerodynamicCoefficientType( ) should return tabulated_coefficients but it is not...

@DominicDirkx
Copy link
Member Author

Hi Aleix, thats odd... Could you attach your main file containing the code?

@aleixpinardell
Copy link
Member

GTO.cpp.zip

DominicDirkx added a commit to DominicDirkx/tudat that referenced this issue Nov 15, 2016
@DominicDirkx
Copy link
Member Author

I patched the code in the branch, if you update it, it should run. Thanks for finding this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants