Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numerical quadrature namespace and trapezoid integrator + unit test #56

Merged
merged 1 commit into from
Sep 5, 2016

Conversation

Reneh107
Copy link
Contributor

@Reneh107 Reneh107 commented Aug 8, 2016

I have made a numerical quadrature folder and the corresponding namespace and I added a trapezoid integrator + unit test

I would like an opinion on the following:

  • Did I implement the baseclass is in a favorable way?
  • Do we want to save data in the integrator class? The trapezoid integrator is now constructed using data and I have two integrate functions, which can be used with and without sending data.
  • We can also just use functions instead of classes, but maybe more functions will be implemented that belong to the method. For example, a measure of the error? I prefer classes instead of single functions.

An additional option would be to add a function: integrate between bounds

@DominicDirkx
Copy link
Member

Hi Rene,

I've had a first look at the code, and I think we can get this into Tudat pretty quickly. I've made some small changes to the code, see

https://github.com/DominicDirkx/tudat/tree/Reneh107-add_numerical_quadrature

I've kept the class structure, but added a free function for the trapezoid quadrature, allowing the user to choose which one to use.

@DominicDirkx DominicDirkx merged commit bbbc0be into Tudat:master Sep 5, 2016
@DominicDirkx
Copy link
Member

I've added a few bits to the unit test to verify the order/symmetry of the method and committed it to teh repository. Thanks for all your hard work Rene!

@gviavattene gviavattene mentioned this pull request Sep 21, 2017
DominicDirkx added a commit to DominicDirkx/tudat that referenced this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants