Extra CMake modules for building boost within project. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've gone through the code: see the tudatBundle pull request #1. |
|
Hi @DominicDirkx thanks for the comments. I have gone through them. Tudat now sucessfully build using MinGW32 GCC 4.8.1. This is the minimum version we can expect to encounter in the wild. One unit test failed, I have addressed this issue by opening an issue #10. |
Add back optimization flags (were disabled to rule out problems). Space vs tab indentation.
|
I've added some comments to the tudatBundle pull request (Tudat/tudatBundle#1). Some small issues remain, but nothing critical. I'll merge these pull requests and update the code according to the remaining issues. We can address the clang issues and the issue of (in)dependence between tudat and tudatBundle in a next issue. |
DominicDirkx
added a commit
that referenced
this pull request
Jan 28, 2016
Extra CMake modules for building boost within project.
DominicDirkx
added a commit
that referenced
this pull request
Feb 2, 2017
Comments on TimeType pull request
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See other accompanying tudatBundle pull request:
Tudat/tudatBundle#1