Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulated aerodynamic coefficients #97

Merged
merged 3 commits into from
Nov 25, 2016
Merged

Tabulated aerodynamic coefficients #97

merged 3 commits into from
Nov 25, 2016

Conversation

aleixpinardell
Copy link
Member

@aleixpinardell aleixpinardell commented Nov 23, 2016

Support added to provide aerodynamic coefficients as a function of altitude.

A unit test has been added. The result of the test on my laptop was:
6/127 Test #6: test_TabulatedAerodynamicCoefficients .................... Passed 2.06 sec
when using a tolerance of 1E-12, but failed for 1E-18. The tolerance is currently set to 1E-12, and thus all the 127 tests passed.

The test uses a list of altitudes and drag coefficients. The other aerodynamic coefficients were always set to 0 and thus they have not been tested.

@DominicDirkx
Copy link
Member

DominicDirkx commented Nov 25, 2016

Hi Aleix,

Thanks for writing the unit test! I made some modifications and will push it to the master shortly.

A few small things:

  • I changed the testing approach a bit: the test now uses the altitude of the output to evaluate the original interpolator, to check whether the coefficients are properly evaluated at each time step. This prevents issues with teh altitude not necessarily being continuously increasing, and focuses more on the correct usage of the aerodynamics during the propagation.

  • For future pull requests, please refer to the style guide of the Tudat website. In particular the verbose naming of all variables, no use of 'using namespace std', maximum 120 line length is important. Also, the Tudat standard is to use a rather liberal amount of white spaces, etc. For consistency, this is also important to adher to.

http://tudat.tudelft.nl/projects/tudat/wiki/N_Commandments
http://tudat.tudelft.nl/projects/tudat/wiki/Style_Guide

  • For future pull requests based on other branches, please pull the relevant branches directly, to keep all contributions from everyone clearly tracked.

@DominicDirkx DominicDirkx merged commit e47aa9d into Tudat:master Nov 25, 2016
@aleixpinardell aleixpinardell deleted the TabulatedAerodynamicCoefficients branch November 25, 2016 13:57
@gviavattene gviavattene mentioned this pull request Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants