Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shortcode "children" must be closed or self-closed #389

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

penyaskito
Copy link
Contributor

Running yarn build gave me an error: shortcode "children" must be closed or self-closed

See gohugoio/hugo#10838

Apparently hugo 0.111 is more restrictive, and hugo 0.111 is the default in e.g. debian 12 repos (I'm using ddev). This should work in any previous version of hugo though.

@q0rban
Copy link
Contributor

q0rban commented Apr 26, 2024

Tested and this works with both yarn build and hugo serve with hugo v0.99.0.

FYI, no need to use ddev for this if you have hugo installed. I guess we need a CONTRIBUTING.md! I thought we had one. 🤔

@q0rban q0rban merged commit 80bc158 into TugboatQA:main Apr 26, 2024
@penyaskito
Copy link
Contributor Author

@q0rban I use ddev for everything, I don't even have node installed locally and just a very old php!

@q0rban
Copy link
Contributor

q0rban commented Apr 26, 2024

sounds good, since we don't have a CONTRIBUTING.md I'll just note that all you need is hugo serve to run this locally, not nodejs unless you want to run the linter or link checker scripts.

@penyaskito
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants