Provide a bleeding edge version #10
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penyaskito
commented
Apr 27, 2024
| @@ -22,7 +22,8 @@ RUN set -x && apt-get update && \ | |||
| cd $DRUPAL_COMPOSER_ROOT && \ | |||
| composer require drush/drush || \ | |||
| # Try drush 11.x-dev if the above fails. | |||
| composer require drush/drush:11.x-dev && \ | |||
| composer require drush/drush:11.x-dev || \ | |||
| composer require drush/drush:13.x-dev && \ | |||
| docker build \ | ||
| --build-arg DRUPAL_VERSION=$(BLEEDING_EDGE_VERSION) \ | ||
| --build-arg PHP_VERSION=$(D11_PHP_VERSION) \ | ||
| -t $(DESTINATION_DOCKER_IMAGE):$(BLEEDING_EDGE_TAG) . |
There was a problem hiding this comment.
This works, but re-creates the bleeding edge one once per existing tag, which is suboptimal (even with all layers cached).
Need to learn more about Makefiles to avoid it.
Didn't do extensive testing of the image, but there might be some permissions issues on settings.php, and drush site-install is not working (might be not our issue, or might be related to the permissions)
There was a problem hiding this comment.
I think this may run on every version.
q0rban
reviewed
Apr 29, 2024
| @@ -56,7 +59,7 @@ targets: ## Print out the available make targets. | |||
| .PHONY: push-image | |||
| push-image: tag ## Push the tagged images to the docker registry. | |||
| # # Push the images. | |||
| docker push --all-tags ${DESTINATION_DOCKER_IMAGE} | |||
| #docker push --all-tags ${DESTINATION_DOCKER_IMAGE} | |||
| docker build \ | ||
| --build-arg DRUPAL_VERSION=$(BLEEDING_EDGE_VERSION) \ | ||
| --build-arg PHP_VERSION=$(D11_PHP_VERSION) \ | ||
| -t $(DESTINATION_DOCKER_IMAGE):$(BLEEDING_EDGE_TAG) . |
There was a problem hiding this comment.
I think this may run on every version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should provide an image of the latest -dev release.