test: run shellcheck

TugboatQA · Oct 1, 2024 · 7d79779 · 7d79779
1 parent 08b4d55
commit 7d79779
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml
@@ -0,0 +1,15 @@
+name: 'Shellcheck'
+on:
+  - push
+jobs:
+  shellcheck:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Run ShellCheck
+        uses: ludeeus/action-shellcheck@203a3fd018dfe73f8ae7e3aa8da2c149a5f41c33
+        env:
+          SHELLCHECK_OPTS: --external-sources --exclude=SC1091
+        with:
+          severity: warning
+          additional_files: 'run finish'
diff --git a/scripts/generate.sh b/scripts/generate.sh
@@ -85,6 +85,7 @@ for tags in $($GETTAGS "${FILTER}"); do
             cp -r "${dir}/files" "${imgdir}/"
         fi
 
+        # shellcheck disable=SC2002
         cat "templates/Dockerfile.${TEMPLATE}.template" | \
             sed "s|{{FROM}}|${image}|g" | \
             sed "/{{DOCKERFILE}}/ r ${dockerfile}" | \

diff --git a/services/solr/finish b/services/solr/finish
@@ -1,3 +1,3 @@
 #!/bin/sh
 
-/opt/solr/bin/solr stop -p ${SOLR_PORT:-8983}
+/opt/solr/bin/solr stop -p "${SOLR_PORT:-8983}"