fix: shut down solr when sv stop solr is called #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apotek
reviewed
Oct 2, 2024
| @@ -69,6 +69,11 @@ for tags in $($GETTAGS "${FILTER}"); do | |||
| cp "${dir}/run" "${imgdir}/run" | |||
| chmod 755 "${imgdir}/run" | |||
| RUN="RUN mkdir -p /etc/service/${SERVICE}\nCOPY run /etc/service/${SERVICE}/run" | |||
| if [ -e "${dir}/finish" ]; then | |||
There was a problem hiding this comment.
It seems it would be much more legible if this $dir variable were named $services_dir or $service_dir. But that's a refactoring not for the faint of heart at this point.
| @@ -0,0 +1,3 @@ | |||
| #!/bin/sh | |||
|
|
|||
| /opt/solr/bin/solr stop -p ${SOLR_PORT:-8983} | |||
There was a problem hiding this comment.
Will be interesting to see if this will also stop the embedded zoo keeper service when run in solrcloud mode. I believe it will since I think the embedded zookeeper service is truly embedded (ie, not a separate process) from the solr server.
There was a problem hiding this comment.
look forward to your testing results! Thank you @apotek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.