-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#149 fix: various issues with image build and test #150
Conversation
ccc7c64
to
1001dc9
Compare
@rabbitlair I'm going to go ahead and merge this in so it's available before the scheduled weekend build, but I would still appreciate your review, in case you have thoughts on things! Each commit should encapsulate a specific problem with the build, in case you want to look that way. |
# Some of our services need a lot of free disk. We run this action to | ||
# free up some disk space, however it is slow, so we conditionally do | ||
# this only on those services that need it. | ||
if: matrix.service == 'opensearch' || matrix.service == 'dynamodb' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All code changes make sense to me. Thank you!
Resolves #149