Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#149 fix: various issues with image build and test #150

Merged
merged 8 commits into from
Oct 4, 2024
Merged

Conversation

q0rban
Copy link
Contributor

@q0rban q0rban commented Oct 3, 2024

Resolves #149

@q0rban q0rban force-pushed the 149--fix-failures branch from ccc7c64 to 1001dc9 Compare October 3, 2024 20:06
@q0rban q0rban requested a review from rabbitlair October 3, 2024 20:21
@q0rban
Copy link
Contributor Author

q0rban commented Oct 4, 2024

@rabbitlair I'm going to go ahead and merge this in so it's available before the scheduled weekend build, but I would still appreciate your review, in case you have thoughts on things! Each commit should encapsulate a specific problem with the build, in case you want to look that way.

@q0rban q0rban merged commit 01cd538 into main Oct 4, 2024
36 checks passed
@q0rban q0rban deleted the 149--fix-failures branch October 4, 2024 13:07
# Some of our services need a lot of free disk. We run this action to
# free up some disk space, however it is slow, so we conditionally do
# this only on those services that need it.
if: matrix.service == 'opensearch' || matrix.service == 'dynamodb'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👏

Copy link
Contributor

@rabbitlair rabbitlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All code changes make sense to me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve various failures in our image builds and tests
2 participants